Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Dec 10, 2020

Proposed changes

There are two points that affect performance in the current json load:
1 json is actually a traversal operation for searching by key. We call HasMember and operator[] twice, and need to traverse twice
2 If you use a string as the key to find the json object, strlen will be called every time, so the number of calls to strlen is the row number * column number

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix improve performance of json load #5054), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should revise some code of timer

@morningman morningman added area/load Issues or PRs related to all kinds of load kind/improvement labels Dec 14, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Dec 14, 2020
@yangzhg yangzhg merged commit 193db42 into apache:master Dec 15, 2020
@yangzhg yangzhg deleted the improve_json_load branch December 22, 2020 07:13
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
…absorb mark join to multi join apache#56837 (apache#5125)

cherry-picks from apache#56837
Related to apache#5055

Co-authored-by: starocean999 <lichi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve performance of json load

3 participants