Skip to content

[Fix](case) Fix case that use time series compaction on unique table #50194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 21, 2025
Merged

[Fix](case) Fix case that use time series compaction on unique table #50194

dataroaring merged 1 commit into from
Apr 21, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Apr 19, 2025 •
edited
Loading

What problem does this PR solve?

some cases in p1/p2 are not modified in #49905

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 19, 2025

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 20, 2025

run p0

2 similar comments
@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 21, 2025

run p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 21, 2025

run p0

zhannngchen
zhannngchen approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 2cca481 into apache:master Apr 21, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 21, 2025
@bobhan1
[Fix](case) Fix case that use time series compaction on unique table (#…
f398d90 
…50194)

some cases in p1/p2 are not modified in
#49905
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
Merged
bobhan1 added a commit to bobhan1/doris that referenced this pull request Apr 21, 2025
@bobhan1
[Fix](case) Fix case that use time series compaction on unique table (a…
b949be4 
…pache#50194)

some cases in p1/p2 are not modified in
apache#49905
@bobhan1 bobhan1 mentioned this pull request Apr 21, 2025
Merged
yiguolei pushed a commit that referenced this pull request Apr 22, 2025
@bobhan1
branch-2.1: [Fix](case) Fix case that use time series compaction on u…
3088aff 
…nique table (#50194) (#50228)

pick #50194
dataroaring pushed a commit that referenced this pull request Apr 22, 2025
@github-actions @bobhan1
branch-3.0: [Fix](case) Fix case that use time series compaction on u…
5449db8 
…nique table #50194 (#50223)

Cherry-picked from #50194

Co-authored-by: bobhan1 <baohan@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@bobhan1 @koarz
[Fix](case) Fix case that use time series compaction on unique table (a…
cb015f9 
…pache#50194)

some cases in p1/p2 are not modified in
apache#49905
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 8, 2025
@bobhan1
(selectdb-cloud-4.0) [Fix](case) Fix case that use time series compac…
a6ea415 
…tion on unique table apache#50194 (apache#50223) (apache#4124)

pick apache#50194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.6-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1 @Thearas @zhannngchen @dataroaring @yiguolei