[fix](function) fix error result when STR_TO_DATE input all space #48872

Mryange · 2025-03-10T10:12:13Z

What problem does this PR solve?

before

mysql> select STR_TO_DATE ('  ', '%Y-%m-%d %H:%i:%s');
+-----------------------------------------+
| STR_TO_DATE ('  ', '%Y-%m-%d %H:%i:%s') |
+-----------------------------------------+
|                                         |
+-----------------------------------------+

now

mysql> select STR_TO_DATE ('  ', '%Y-%m-%d %H:%i:%s');
+-----------------------------------------+
| STR_TO_DATE ('  ', '%Y-%m-%d %H:%i:%s') |
+-----------------------------------------+
| NULL                                    |
+-----------------------------------------+

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-03-10T10:12:18Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Mryange · 2025-03-10T10:12:29Z

run buildall

doris-robot · 2025-03-10T10:43:53Z

TPC-H: Total hot run time: 32611 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ce1b8a2287500eb31ca7d15e5f7c5edc2b61a814, data reload: false

------ Round 1 ----------------------------------
q1	17583	5213	5091	5091
q2	2041	293	160	160
q3	10425	1261	779	779
q4	10209	1012	532	532
q5	7545	2401	2351	2351
q6	192	161	129	129
q7	904	736	605	605
q8	9299	1315	1160	1160
q9	4927	4583	4871	4583
q10	7119	2358	1940	1940
q11	508	275	264	264
q12	372	366	221	221
q13	17780	3755	3130	3130
q14	222	225	206	206
q15	540	479	474	474
q16	633	625	597	597
q17	573	862	354	354
q18	6706	6399	6362	6362
q19	2775	973	578	578
q20	306	321	188	188
q21	2833	2161	1954	1954
q22	1043	1036	953	953
Total cold run time: 104535 ms
Total hot run time: 32611 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5333	5170	5173	5170
q2	245	334	233	233
q3	2155	2644	2303	2303
q4	1425	1865	1376	1376
q5	4237	4094	4179	4094
q6	202	171	122	122
q7	1943	1943	1775	1775
q8	2650	2627	2547	2547
q9	7226	7200	7129	7129
q10	3018	3233	2770	2770
q11	569	519	486	486
q12	706	725	600	600
q13	3541	4041	3319	3319
q14	292	296	288	288
q15	520	483	500	483
q16	658	717	641	641
q17	1140	1621	1343	1343
q18	7798	7577	7530	7530
q19	870	897	1053	897
q20	1962	2044	1861	1861
q21	5608	4972	4743	4743
q22	1135	1052	1007	1007
Total cold run time: 53233 ms
Total hot run time: 50717 ms

doris-robot · 2025-03-10T10:56:12Z

TPC-DS: Total hot run time: 193757 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ce1b8a2287500eb31ca7d15e5f7c5edc2b61a814, data reload: false

query1	1410	996	1003	996
query2	6236	1896	1886	1886
query3	10981	4387	4422	4387
query4	55819	26052	23381	23381
query5	5091	528	500	500
query6	359	192	196	192
query7	4971	515	298	298
query8	339	252	240	240
query9	6368	2638	2640	2638
query10	439	322	263	263
query11	15320	15159	15125	15125
query12	162	119	107	107
query13	1120	521	434	434
query14	10438	7306	6939	6939
query15	212	212	181	181
query16	7193	629	491	491
query17	1105	758	607	607
query18	1523	406	325	325
query19	198	203	167	167
query20	121	118	118	118
query21	207	130	108	108
query22	4368	4519	4512	4512
query23	33867	33531	33528	33528
query24	5753	2451	2423	2423
query25	452	490	429	429
query26	703	280	154	154
query27	1737	515	332	332
query28	2803	2493	2455	2455
query29	590	575	429	429
query30	294	228	192	192
query31	893	893	767	767
query32	78	65	63	63
query33	450	395	304	304
query34	768	859	513	513
query35	814	849	769	769
query36	989	977	929	929
query37	121	107	75	75
query38	4156	4254	4205	4205
query39	1506	1449	1417	1417
query40	213	118	110	110
query41	56	51	49	49
query42	120	103	108	103
query43	505	506	494	494
query44	1427	841	824	824
query45	185	176	197	176
query46	859	1046	651	651
query47	1836	1851	1799	1799
query48	401	445	314	314
query49	697	525	409	409
query50	728	761	427	427
query51	4313	4356	4248	4248
query52	118	107	101	101
query53	242	273	190	190
query54	512	536	430	430
query55	85	84	86	84
query56	301	288	272	272
query57	1177	1171	1119	1119
query58	254	266	258	258
query59	2598	2882	2667	2667
query60	294	292	289	289
query61	153	120	120	120
query62	746	729	669	669
query63	232	199	191	191
query64	1740	1056	702	702
query65	4559	4456	4434	4434
query66	749	415	309	309
query67	15839	15454	15224	15224
query68	7152	880	509	509
query69	543	317	265	265
query70	1182	1060	1098	1060
query71	510	299	271	271
query72	5892	3771	3853	3771
query73	1349	753	349	349
query74	9018	9052	8951	8951
query75	3712	3172	2731	2731
query76	4297	1184	772	772
query77	618	369	278	278
query78	10001	9997	9359	9359
query79	3465	846	591	591
query80	723	549	466	466
query81	491	265	218	218
query82	685	139	100	100
query83	311	178	164	164
query84	290	100	71	71
query85	922	360	338	338
query86	372	294	303	294
query87	4495	4554	4418	4418
query88	3180	2293	2321	2293
query89	423	324	296	296
query90	1949	226	233	226
query91	148	147	112	112
query92	74	60	59	59
query93	1574	1062	593	593
query94	705	419	298	298
query95	352	278	267	267
query96	501	576	288	288
query97	3403	3420	3311	3311
query98	224	211	198	198
query99	1478	1400	1298	1298
Total cold run time: 300932 ms
Total hot run time: 193757 ms

doris-robot · 2025-03-10T11:01:29Z

ClickBench: Total hot run time: 30.76 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ce1b8a2287500eb31ca7d15e5f7c5edc2b61a814, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.11
query5	0.57	0.55	0.55
query6	1.19	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.51	0.53
query10	0.59	0.58	0.59
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	2.65	2.84	2.70
query15	0.90	0.87	0.85
query16	0.38	0.40	0.39
query17	1.02	1.02	1.03
query18	0.22	0.20	0.20
query19	1.87	1.78	2.01
query20	0.01	0.01	0.01
query21	15.37	0.89	0.54
query22	0.74	1.20	0.99
query23	14.70	1.40	0.62
query24	6.89	1.98	0.41
query25	0.49	0.17	0.18
query26	0.54	0.16	0.13
query27	0.06	0.05	0.05
query28	9.81	0.87	0.43
query29	12.57	3.99	3.34
query30	0.25	0.09	0.06
query31	2.83	0.59	0.40
query32	3.22	0.53	0.46
query33	3.01	3.06	3.01
query34	15.70	5.12	4.47
query35	4.53	4.53	4.49
query36	0.65	0.50	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.8 s
Total hot run time: 30.76 s

regression-test/suites/correctness/test_str_to_date.groovy

Mryange · 2025-03-10T13:23:16Z

run buildall

doris-robot · 2025-03-10T13:48:30Z

TPC-H: Total hot run time: 32405 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d41865f10ecee288f6235aecfc16073f9f87a194, data reload: false

------ Round 1 ----------------------------------
q1	17634	5236	5033	5033
q2	2046	289	167	167
q3	10416	1259	699	699
q4	10220	1008	531	531
q5	7526	2346	2337	2337
q6	190	167	138	138
q7	917	745	602	602
q8	9304	1311	1039	1039
q9	4920	4790	4765	4765
q10	6804	2304	1908	1908
q11	478	279	262	262
q12	358	362	225	225
q13	17758	3670	3034	3034
q14	221	230	213	213
q15	536	481	487	481
q16	637	616	613	613
q17	568	853	343	343
q18	7048	6496	6316	6316
q19	1654	954	578	578
q20	334	320	196	196
q21	2787	2296	1928	1928
q22	1021	1019	997	997
Total cold run time: 103377 ms
Total hot run time: 32405 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5181	5075	5109	5075
q2	236	330	231	231
q3	2116	2656	2275	2275
q4	1449	1800	1352	1352
q5	4243	4131	4142	4131
q6	208	165	128	128
q7	1856	1921	1772	1772
q8	2599	2637	2585	2585
q9	7240	7141	7240	7141
q10	2971	3180	2743	2743
q11	584	508	491	491
q12	666	751	627	627
q13	3496	3872	3270	3270
q14	284	284	265	265
q15	503	488	488	488
q16	645	667	651	651
q17	1115	1572	1375	1375
q18	7615	7519	7476	7476
q19	844	920	1086	920
q20	1942	2018	1897	1897
q21	5527	4871	4848	4848
q22	1115	1077	1019	1019
Total cold run time: 52435 ms
Total hot run time: 50760 ms

doris-robot · 2025-03-10T14:00:05Z

TPC-DS: Total hot run time: 185612 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d41865f10ecee288f6235aecfc16073f9f87a194, data reload: false

query1	1017	394	369	369
query2	6534	1861	1870	1861
query3	6794	221	217	217
query4	26732	23445	23083	23083
query5	4323	654	484	484
query6	283	183	175	175
query7	4602	498	294	294
query8	312	254	244	244
query9	8607	2656	2644	2644
query10	486	309	274	274
query11	15814	15091	14980	14980
query12	163	112	112	112
query13	1655	511	417	417
query14	10053	6704	6796	6704
query15	200	193	168	168
query16	7675	658	467	467
query17	1197	718	564	564
query18	1985	407	318	318
query19	203	188	170	170
query20	128	125	117	117
query21	213	121	105	105
query22	4115	4205	4149	4149
query23	33777	32903	33013	32903
query24	7663	2359	2360	2359
query25	519	460	398	398
query26	1229	265	149	149
query27	2118	491	320	320
query28	3917	2442	2405	2405
query29	706	560	415	415
query30	302	219	193	193
query31	938	866	785	785
query32	72	64	62	62
query33	557	368	298	298
query34	776	843	499	499
query35	802	817	757	757
query36	972	996	879	879
query37	117	99	79	79
query38	4106	4170	4047	4047
query39	1479	1405	1433	1405
query40	208	114	104	104
query41	54	49	50	49
query42	116	105	101	101
query43	476	499	483	483
query44	1286	800	798	798
query45	199	168	184	168
query46	832	1028	622	622
query47	1786	1826	1734	1734
query48	376	403	302	302
query49	782	496	436	436
query50	672	722	410	410
query51	4152	4206	4160	4160
query52	106	109	98	98
query53	224	254	192	192
query54	492	497	416	416
query55	81	83	86	83
query56	258	271	253	253
query57	1124	1147	1063	1063
query58	254	243	227	227
query59	2667	2615	2611	2611
query60	285	275	248	248
query61	123	126	120	120
query62	812	730	650	650
query63	219	186	185	185
query64	4280	981	663	663
query65	4435	4352	4395	4352
query66	1045	403	300	300
query67	16015	15508	15332	15332
query68	8194	877	516	516
query69	461	306	269	269
query70	1212	1102	1103	1102
query71	473	292	290	290
query72	5576	3637	3725	3637
query73	799	719	345	345
query74	9175	9216	8700	8700
query75	3802	3147	2726	2726
query76	3682	1183	784	784
query77	782	367	280	280
query78	10062	10000	9288	9288
query79	2995	831	590	590
query80	705	521	452	452
query81	487	250	217	217
query82	713	124	92	92
query83	219	172	165	165
query84	290	97	72	72
query85	812	363	309	309
query86	385	291	293	291
query87	4445	4485	4395	4395
query88	3593	2297	2241	2241
query89	388	325	283	283
query90	1870	216	206	206
query91	152	136	108	108
query92	82	60	57	57
query93	1953	1043	575	575
query94	660	421	304	304
query95	359	271	262	262
query96	482	557	274	274
query97	3330	3359	3302	3302
query98	232	211	205	205
query99	1455	1355	1246	1246
Total cold run time: 276325 ms
Total hot run time: 185612 ms

doris-robot · 2025-03-10T14:05:22Z

ClickBench: Total hot run time: 31.3 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d41865f10ecee288f6235aecfc16073f9f87a194, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.55	0.56	0.55
query6	1.17	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.52	0.51
query10	0.56	0.62	0.58
query11	0.17	0.12	0.11
query12	0.15	0.11	0.11
query13	0.62	0.61	0.60
query14	2.83	2.69	2.83
query15	0.91	0.87	0.84
query16	0.38	0.37	0.37
query17	1.03	1.04	1.01
query18	0.23	0.20	0.21
query19	1.96	1.81	2.01
query20	0.01	0.01	0.01
query21	15.37	0.94	0.55
query22	0.75	1.27	0.92
query23	14.75	1.41	0.68
query24	7.37	1.00	1.34
query25	0.51	0.30	0.08
query26	0.60	0.16	0.13
query27	0.05	0.05	0.05
query28	9.17	0.88	0.44
query29	12.63	4.10	3.38
query30	0.25	0.10	0.06
query31	2.82	0.59	0.38
query32	3.24	0.55	0.46
query33	3.03	2.95	2.99
query34	15.77	5.22	4.55
query35	4.54	4.54	4.52
query36	0.65	0.50	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 105.17 s
Total hot run time: 31.3 s

Mryange · 2025-03-10T16:17:34Z

run beut

doris-robot · 2025-03-10T18:01:03Z

BE UT Coverage Report

Increment line coverage 0.00% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	46.84% (12520/26730)
Line Coverage	36.54% (106953/292724)
Region Coverage	35.58% (54655/153632)
Branch Coverage	31.00% (27552/88866)

github-actions · 2025-03-11T02:56:54Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-03-11T02:56:57Z

PR approved by anyone and no changes requested.

…ache#48872) before ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | | +-----------------------------------------+ ``` now ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | NULL | +-----------------------------------------+ ``` Problem Summary: None - Test  - [x] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

#48920) …8872) #48872 before ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | | +-----------------------------------------+ ``` now ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | NULL | +-----------------------------------------+ ``` Problem Summary: None - Test  - [x] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label  ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

#48921) …8872) #48872 before ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | | +-----------------------------------------+ ``` now ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | NULL | +-----------------------------------------+ ```

…ache#48872) ### What problem does this PR solve? before ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | | +-----------------------------------------+ ``` now ``` mysql> select STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s'); +-----------------------------------------+ | STR_TO_DATE (' ', '%Y-%m-%d %H:%i:%s') | +-----------------------------------------+ | NULL | +-----------------------------------------+ ``` Problem Summary: ### Release note None ### Check List (For Author) - Test  - [x] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

fix

ce1b8a2

zclllyybb reviewed Mar 10, 2025

View reviewed changes

regression-test/suites/correctness/test_str_to_date.groovy Show resolved Hide resolved

be-ut

d41865f

BiteTheDDDDt approved these changes Mar 11, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2025

github-actions bot added the reviewed label Mar 11, 2025

zhangstar333 approved these changes Mar 11, 2025

View reviewed changes

zhangstar333 merged commit 24b7b95 into apache:master Mar 11, 2025
25 of 28 checks passed

yiguolei added usercase Important user case type label dev/2.1.x dev/3.0.x labels Mar 11, 2025

github-actions bot added dev/2.1.x-conflict dev/3.0.x-conflict labels Mar 11, 2025

Mryange mentioned this pull request Mar 11, 2025

[fix](function) fix error result when STR_TO_DATE input all space (#4… #48920

Merged

29 tasks

Mryange mentioned this pull request Mar 11, 2025

[fix](function) fix error result when STR_TO_DATE input all space (#4… #48921

Merged

29 tasks

yiguolei added dev/2.1.9-merged and removed dev/2.1.x dev/2.1.x-conflict labels Mar 11, 2025

dataroaring added dev/3.0.6-merged and removed dev/3.0.x dev/3.0.x-conflict labels Apr 22, 2025

[fix](function) fix error result when STR_TO_DATE input all space #48872

[fix](function) fix error result when STR_TO_DATE input all space #48872

Uh oh!

Conversation

Mryange commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Mar 10, 2025

Uh oh!

Mryange commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

Uh oh!

Uh oh!

Mryange commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

Uh oh!

Mryange commented Mar 10, 2025

Uh oh!

doris-robot commented Mar 10, 2025

BE UT Coverage Report

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Mryange commented Mar 10, 2025 •

edited

Loading