[Bug] Tablet and Disk report thread not work #4597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tablet and disk information reporting threads need to report to the FE periodically. At the same time these two reporting threads will also be triggered by certain events. The modification in PR apache#4440 caused these two threads to be triggered only by events, and could not report regularly.
acelyc111
reviewed
Sep 14, 2020
be/src/agent/task_worker_pool.cpp
Outdated
| if (status != DORIS_SUCCESS) { | ||
| DorisMetrics::instance()->report_task_requests_failed->increment(1); | ||
| LOG(WARNING) << "finish report task failed. status:" << status << ", master host:" | ||
| LOG(WARNING) << "report task failed. status:" << status << ", master host:" |
Member
There was a problem hiding this comment.
Suggested change
| LOG(WARNING) << "report task failed. status:" << status << ", master host:" | |
| LOG(WARNING) << "report task failed. status: " << status << ", master host: " |
be/src/olap/storage_engine.cpp
Outdated
Comment on lines
983
to
985
| if (submit_task) { | ||
| TAgentTaskRequest task; | ||
| listener->submit_task(task); |
Member
There was a problem hiding this comment.
Seems all callers pass a 'false' parameter, how about remove these code?
|
|
||
| class TaskWorkerPool { | ||
| public: | ||
| // You need to modify the content in TYPE_STRING at the same time, |
Member
There was a problem hiding this comment.
Maybe it's not easy to keep order consistency some days later, how about use a function to get name of type?
acelyc111
approved these changes
Sep 14, 2020
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The tablet and disk information reporting threads need to report to the FE periodically.
At the same time these two reporting threads will also be triggered by certain events.
The modification in PR #4440 caused these two threads to be triggered only by events,
and could not report regularly.
Types of changes