[Bug](runtime-filter) avoid wrong partitial ignore minmax filter #43078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
zhangstar333
approved these changes
Nov 4, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Nov 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
) In ##41667 we support ignore filter partitial, however, when sync_filter_size is turned off, the final filter may only contain part of the data because some filters are judged to be 'in'. For example: there are rf001(2 instances, in_or_bloom),rf000(2 instances, min_max), instance_1 has 1e8 row and rf001 change to bloom, the rf000 will not ignored instance_2 has 1 row and rf001 change to in, the rf000 will ignored finally, rf000 applied and make wrong result
BiteTheDDDDt
added a commit
that referenced
this pull request
Nov 27, 2024
) In ##41667 we support ignore filter partitial, however, when sync_filter_size is turned off, the final filter may only contain part of the data because some filters are judged to be 'in'. For example: there are rf001(2 instances, in_or_bloom),rf000(2 instances, min_max), instance_1 has 1e8 row and rf001 change to bloom, the rf000 will not ignored instance_2 has 1 row and rf001 change to in, the rf000 will ignored finally, rf000 applied and make wrong result
BiteTheDDDDt
added a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ##41667 we support ignore filter partitial, however, when sync_filter_size is turned off, the final filter may only contain part of the data because some filters are judged to be 'in'.
For example:
there are rf001(2 instances, in_or_bloom),rf000(2 instances, min_max),
instance_1 has 1e8 row and rf001 change to bloom, the rf000 will not ignored
instance_2 has 1 row and rf001 change to in, the rf000 will ignored
finally, rf000 applied and make wrong result