[BUG] Using attachement strategy of brpc to send packet with big size. #4237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRPC send packet should serialize it first and then send it. If we send one batch with big size, it will encounter a connection failed. So we can use attachment strategy to bypass the problem and eliminate the serialization cost.
imay
requested changes
Aug 3, 2020
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Aug 6, 2020
…big size. (apache#4237)" This reverts commit 120f30b.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Aug 6, 2020
…et with big size. (apache#4237)"" This reverts commit 4b7e97d.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BRPC send packet should serialize it first and then send it.
If we send one batch with big size, it will encounter a connection failed.
So we can use attachment strategy to bypass the problem and eliminate
the serialization cost.