Change type of sum, min, max function column in mv #4199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the agg function is sum, the type of mv column will be bigint. The only exception is that if the base column is largeint, the type of mv column will be largeint. If the agg function is min or max, the type of mv column will be same as the type of base column. For example, the type of mv column is smallint when the agg function is min. Change-Id: I1b541fd03342ceba093c4aabd8a29793c52781dc
Contributor
|
Please add a UT to cover this PR. |
wutiangan
suggested changes
Jul 28, 2020
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Show resolved
Hide resolved
Change-Id: Id451b0f7b334e265e1b495ee0aa47a686fffc1ee
Change-Id: Iffb7d3d7cbac6e98f4f358dd7c98a7d0dea2d4fc
Contributor
Author
Added |
Contributor
@EmmyMiao87 Hi. for sum(double), sum(decimal), the type of mv column will also be bigint? |
…v column will be bigint. Otherwise, the type of mv column is same as the type of base column. Change-Id: I39b869c18a24b2e8506bfbea22be781488132d69
Contributor
Author
Fixed |
kangkaisen
reviewed
Jul 28, 2020
| || baseColumnType == PrimitiveType.INT) { | ||
| type = Type.BIGINT; | ||
| } else { | ||
| type = Type.fromPrimitiveType(baseColumnRef.getType().getPrimitiveType()); |
Contributor
There was a problem hiding this comment.
Sum float result type should be double.
Change-Id: I14387f5b1a3654e8c9fe9d8f46f78d51a8ab7ce1
Merged
morningman
pushed a commit
that referenced
this pull request
Aug 6, 2020
Revert “Change type of sum, min, max function column in mv” This pr is revert pr #4199 . The daily test is cored when the type of mv column has been changed. So I revert the pr. The daily core will be fixed in the future. After that, the pr#4199 will be enable. Change-Id: Ie04fcfacfcd38480121addc5e454093d4ae75181
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Jul 30, 2025
…r line delimiter (apache#53374) (apache#4199) pick [(apache#53374)](apache#53374) Multiple concurrent split file locations will be determined in plan phase, if the split point happens to be in the middle of the multi char line delimiter: - The previous concurrent will read the complete row1 and read a little more to read the line delimiter. - The latter concurrency will start reading from half of the multi char line delimiter, and row2 is the first line of this concurrency, but the first line in the middle range is always discarded, so row2 will be lost. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If the agg function is sum, the type of mv column will be bigint.
The only exception is that if the base column is largeint, the type of mv column will be largeint.
If the agg function is min or max, the type of mv column will be same as the type of base column.
For example, the type of mv column is smallint when the agg function is min.
Change-Id: I1b541fd03342ceba093c4aabd8a29793c52781dc
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.