Skip to content

Conversation

@xieyiyi
Copy link

@xieyiyi xieyiyi commented Jul 23, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Doris's issues, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related issues ID, like "Add pull request template to doris project #4071 Add pull request template to doris project"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

xieyiyi added 2 commits July 23, 2020 14:22
bash is not the default sh in several environments, but the '[[' grammer is not supported by the default sh.
So when bash is not specified, in some cases "[[: not found" exception will raise.
* Start FE

`sh bin/start_fe.sh --daemon`
`bash bin/start_fe.sh --daemon`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that start_fe.sh has '#!/usr/bin/env bash'. So system will use bash call this shell.
So I think following will be better.

Suggested change
`bash bin/start_fe.sh --daemon`
`./bin/start_fe.sh --daemon`

@jackwener
Copy link
Member

Long time passed. And I find this PR isn't essential. Close it.
If you have some question, feel free to contact me by @jackwener / reopen this PR.

@jackwener jackwener closed this May 22, 2022
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants