Skip to content

Conversation

@HappenLee
Copy link
Contributor

1. Add Exec msg for BufferedBlockMgr for debug tuning
2. Change the API of Consume Memory? We will use it in HashTable in the future
3. Fix mistake of count _unfullfilled_reserved_buffers  in BufferedBlockMgr

issue:#3926

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Doris's issues, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related issues ID, like "Add pull request template to doris project #4071 Add pull request template to doris project"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

…ludes the following change

    1. Add Exec msg for BufferedBlockMgr for debug tuning
    2. Change the API of Consume Memory? We will use it in HashTable in the future
    3. Fix mistake of count _unfullfilled_reserved_buffers  in BufferedBlockMgr

issue:apache#3926
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Jul 29, 2020
@morningman morningman added approved Indicates a PR has been approved by one committer. kind/improvement labels Jul 29, 2020
@kangkaisen kangkaisen merged commit 594e53e into apache:master Jul 30, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Sep 1, 2020
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Sep 1, 2025
…#51948) (apache#4151)

### What problem does this PR solve?

Support GROUP BY ... WITH ROLLUP syntax

mysql> SELECT year, month, SUM(amount) AS total_amount FROM sales GROUP
BY year, month WITH ROLLUP order by year desc, month desc;
+------+-------+--------------+
| year | month | total_amount |
+------+-------+--------------+
| 2024 |     1 |      3400.00 |
| 2024 |  NULL |      3400.00 |
| 2023 |     2 |      4000.00 |
| 2023 |     1 |      3000.00 |
| 2023 |  NULL |      7000.00 |
| NULL |  NULL |     10400.00 |
+------+-------+--------------+
6 rows in set (0.02 sec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants