[cherry-pick](branch-2.0) Pick "[Enhancement](full compaction) Add run status support for full compaction (#34043)" #37607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
…tion (apache#34043) * The usage is `curl http://{ip}:{host}/api/compaction/run_status?tablet_id={tablet_id}` e.g. `curl http://127.0.0.1:8040/api/compaction/run_status?tablet_id=10084` If full compaction is running, the output will be ``` { "status" : "Success", "run_status" : true, "msg" : "compaction task for this tablet is running", "tablet_id" : 10084, "compact_type" : "full" } ``` else the ouput will be ``` { "status" : "Success", "run_status" : false, "msg" : "compaction task for this tablet is not running", "tablet_id" : 10084, "compact_type" : "full" } ``` * 2
29a0539 to
d621860
Compare
Collaborator
Author
|
run buildall |
| : Compaction(tablet, "FullCompaction:" + std::to_string(tablet->tablet_id())) {} | ||
|
|
||
| FullCompaction::~FullCompaction() {} | ||
| FullCompaction::~FullCompaction() { |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
FullCompaction::~FullCompaction() {
^
TPC-H: Total hot run time: 49959 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 202814 ms |
ClickBench: Total hot run time: 30.5 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…n status support for full compaction (apache#34043)" (apache#37607) Pick apache#34043 The usage is `curl http://{ip}:{host}/api/compaction/run_status?tablet_id={tablet_id}` e.g. `curl http://127.0.0.1:8040/api/compaction/run_status?tablet_id=10084` If full compaction is running, the output will be ``` { "status" : "Success", "run_status" : true, "msg" : "compaction task for this tablet is running", "tablet_id" : 10084, "compact_type" : "full" } ``` else the ouput will be ``` { "status" : "Success", "run_status" : false, "msg" : "compaction task for this tablet is not running", "tablet_id" : 10084, "compact_type" : "full" } ``` ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick #34043
The usage is
curl http://{ip}:{host}/api/compaction/run_status?tablet_id={tablet_id}e.g.curl http://127.0.0.1:8040/api/compaction/run_status?tablet_id=10084If full compaction is running, the output will be
else the ouput will be
Proposed changes
Issue Number: close #xxx