Skip to content

[fix](txn) Fix coordidator be restart not abort txn #35342 #36437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jun 25, 2024
Merged

[fix](txn) Fix coordidator be restart not abort txn #35342 #36437

dataroaring merged 2 commits into from
Jun 25, 2024

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Jun 18, 2024

cherry pick from #35342

@yujun777
Copy link
Contributor Author

yujun777 commented Jun 18, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777 yujun777 marked this pull request as draft June 18, 2024 02:34
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.30% (9132/25156)
Line Coverage: 27.79% (74262/267225)
Region Coverage: 26.73% (38324/143395)
Branch Coverage: 23.40% (19409/82928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/36a6091e9dbc2457f3a349174cf6dd714c395570_36a6091e9dbc2457f3a349174cf6dd714c395570/report/index.html

@yujun777 yujun777 force-pushed the pick_35342_to_upstream_branch-2.1 branch from 36a6091 to dd7051e Compare June 19, 2024 02:56
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@yujun777 yujun777 marked this pull request as ready for review June 19, 2024 08:03
@yujun777
Copy link
Contributor Author

yujun777 commented Jun 19, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

TeamCity be ut coverage result:
Function Coverage: 36.29% (9130/25158)
Line Coverage: 27.79% (74248/267217)
Region Coverage: 26.72% (38312/143382)
Branch Coverage: 23.41% (19407/82898)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bcebbc83761921cf4c75e38dd30792e060861b3b_bcebbc83761921cf4c75e38dd30792e060861b3b/report/index.html

@dataroaring dataroaring merged commit 785a1f4 into apache:branch-2.1 Jun 25, 2024
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
Closed
1 task
@yujun777 yujun777 mentioned this pull request Aug 23, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 23, 2024
@yujun777
[branch-2.1](thrift) fix TLoadTxnBeginRequest backend_id's field no (#…
8bbd3db 
…39823)

Make backend_id's field no the same with master branch.

For upgrading, change backend_id's field no is safe, because old fe can
torrent with TLoadTxnBeginRequest not setting backend id.

backend_id was introduce by #36437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yujun777 @doris-robot @dataroaring