-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](plan) wrong result for random distributed agg table with all keys not null #36270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 40079 ms |
TPC-DS: Total hot run time: 173333 ms |
ClickBench: Total hot run time: 30.42 s |
lide-reed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xy720
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Issue Number: close #36072
In pr #33630, we already support auto aggregation for random distributed table.
But if all keys are
NOT NULL, the aggregation will be eliminated by the rule:ELIMINATE_GROUP_BYThis pr we prevent
ELIMINATE_GROUP_BYwork for random distributed table.