[feat](nereids) support create view in nereids #32743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37763 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38292 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38149 ms |
TPC-DS: Total hot run time: 182077 ms |
ClickBench: Total hot run time: 29.87 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38538 ms |
TPC-DS: Total hot run time: 182456 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38503 ms |
TPC-DS: Total hot run time: 180922 ms |
ClickBench: Total hot run time: 30.65 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
Apr 11, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Apr 11, 2024
liutang123
added a commit
to liutang123/doris
that referenced
this pull request
Apr 12, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 12, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 13, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 13, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 15, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 17, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
morrySnow
pushed a commit
that referenced
this pull request
Oct 23, 2024
…42206) This is brought by #32743 set enable_unicode_name_support = true; If run create view sql should fail beausel_shipdate column name contains invalid char '(' and ')', but now success this pr fix this and throw exception `ERROR 1105 (HY000): errCode = 2, detailMessage = Incorrect column name '(日期)'. Column regex is '^[_a-zA-Z@0-9\s/][.a-zA-Z0-9_+-/?@#$%^&*"\s,:]{0,255}$'` CREATE VIEW view1 AS SELECT "零售公司", l_shipdate as '(日期)', l_receiptdate as k2 FROM lineitem; and if run create view sql as following, should success: CREATE VIEW view2 AS SELECT "零售公司", l_shipdate as '日期', l_receiptdate as k2 FROM lineitem; and the schema of view2 should be mysql> desc view2; +-------------+-------------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------------+-------------+------+-------+---------+-------+ | __literal_0 | varchar(16) | No | false | NULL | | | 日期 | date | No | false | NULL | | | k2 | date | No | false | NULL | | +-------------+-------------+------+-------+---------+-------+ 3 rows in set (0.01 sec)
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Oct 23, 2024
…pache#42206) This is brought by apache#32743 set enable_unicode_name_support = true; If run create view sql should fail beausel_shipdate column name contains invalid char '(' and ')', but now success this pr fix this and throw exception `ERROR 1105 (HY000): errCode = 2, detailMessage = Incorrect column name '(日期)'. Column regex is '^[_a-zA-Z@0-9\s/][.a-zA-Z0-9_+-/?@#$%^&*"\s,:]{0,255}$'` CREATE VIEW view1 AS SELECT "零售公司", l_shipdate as '(日期)', l_receiptdate as k2 FROM lineitem; and if run create view sql as following, should success: CREATE VIEW view2 AS SELECT "零售公司", l_shipdate as '日期', l_receiptdate as k2 FROM lineitem; and the schema of view2 should be mysql> desc view2; +-------------+-------------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------------+-------------+------+-------+---------+-------+ | __literal_0 | varchar(16) | No | false | NULL | | | 日期 | date | No | false | NULL | | | k2 | date | No | false | NULL | | +-------------+-------------+------+-------+---------+-------+ 3 rows in set (0.01 sec)
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Oct 23, 2024
…pache#42206) This is brought by apache#32743 set enable_unicode_name_support = true; If run create view sql should fail beausel_shipdate column name contains invalid char '(' and ')', but now success this pr fix this and throw exception `ERROR 1105 (HY000): errCode = 2, detailMessage = Incorrect column name '(日期)'. Column regex is '^[_a-zA-Z@0-9\s/][.a-zA-Z0-9_+-/?@#$%^&*"\s,:]{0,255}$'` CREATE VIEW view1 AS SELECT "零售公司", l_shipdate as '(日期)', l_receiptdate as k2 FROM lineitem; and if run create view sql as following, should success: CREATE VIEW view2 AS SELECT "零售公司", l_shipdate as '日期', l_receiptdate as k2 FROM lineitem; and the schema of view2 should be mysql> desc view2; +-------------+-------------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------------+-------------+------+-------+---------+-------+ | __literal_0 | varchar(16) | No | false | NULL | | | 日期 | date | No | false | NULL | | | k2 | date | No | false | NULL | | +-------------+-------------+------+-------+---------+-------+ 3 rows in set (0.01 sec)
16 tasks
zy-kkk
pushed a commit
that referenced
this pull request
May 19, 2025
Related PR: #32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
github-actions bot
pushed a commit
that referenced
this pull request
May 19, 2025
Related PR: #32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
github-actions bot
pushed a commit
that referenced
this pull request
May 19, 2025
Related PR: #32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
Related PR: apache#32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr supports create view stmt in nereids planner. For example: