-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](build index) fix core when build index for a new column which without data #32550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
eb32404 to
68db50d
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run external |
1 similar comment
|
run external |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run external |
1 similar comment
|
run external |
68db50d to
6a54aae
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38092 ms |
TPC-DS: Total hot run time: 182430 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ithout data (apache#32550) Co-authored-by: Luennng <luennng@gmail.com> Co-authored-by: Tanya-W <tanya1218w@163,com>
…ithout data (apache#32550) (apache#32669) Co-authored-by: Luennng <luennng@gmail.com> Co-authored-by: Tanya-W <tanya1218w@163,com>
Proposed changes
Issue Number: close #27156
pick from #27276
Also add column_uid check.
When updating inverted Index info, we need to check whether the column_unique_id is -1 or not.
If it is -1, it indicates the column is added by schema change and dose not sync with be for now.
So we skip check the exist_index, which will causes map out_of_range.
Co-authored-by: Tanya-W <tanya1218w@163,com>
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...