Skip to content

[fix](partition) Comment out some exceptions with partition equal to … #28702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Dec 29, 2023
Merged

[fix](partition) Comment out some exceptions with partition equal to … #28702

yiguolei merged 2 commits into from
Dec 29, 2023
+14 −4

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Dec 20, 2023

…0 and return

In some scenarios, the partition id in the table meta is 0, but the rowset meta partition is not 0, (#28055) PR check partition id will caused be failed to start when upgrade

meta like this

{
    "table_id": 1266302,
    "partition_id": 0,
    "tablet_id": 1289222,
    "schema_hash": 816078096,
    "shard_id": 949,
    "creation_time": 1684805433,
    "cumulative_layer_point": -1,
    "tablet_state": "PB_RUNNING",
    "schema": {
        "keys_type": "DUP_KEYS",
        "column": [
	    ...
        ],
        "num_short_key_columns": 1,
        "num_rows_per_row_block": 1024,
	...
        "skip_write_index_on_load": false
    },
    "rs_metas": [
        {
            "rowset_id": 0,
            "partition_id": 1289193,
            "tablet_id": 1289222,
            "tablet_schema_hash": 816078096,
            "newest_write_timestamp": 1684805433,
	    ...
            "segments_overlap_pb": "NONOVERLAPPING"
        }
    ],
    "in_restore_mode": false,
    "tablet_uid": {
        "hi": -4301918259617109775,
        "lo": 2820124814688031668
    },
    "preferred_rowset_type": "BETA_ROWSET",
    "tablet_type": "TABLET_TYPE_DISK",
    "replica_id": 1812028,
    "enable_unique_key_merge_on_write": false,
    "binlog_config": {
        "enable": false,
        "ttl_seconds": 9223372036854775807,
        "max_bytes": 9223372036854775807,
        "max_history_nums": 9223372036854775807
    },
    "compaction_policy": "size_based",
    "time_series_compaction_goal_size_mbytes": 1024,
    "time_series_compaction_file_count_threshold": 2000,
    "time_series_compaction_time_threshold_seconds": 3600
}

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@deardeng
Copy link
Contributor Author

deardeng commented Dec 20, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 20, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 14344281303ae3b4fcd8ff250d40974603968801, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4718	4452	4458	4452
q2	361	155	166	155
q3	1472	1274	1205	1205
q4	1109	907	915	907
q5	3162	3160	3180	3160
q6	244	126	130	126
q7	1009	473	481	473
q8	2217	2223	2199	2199
q9	6704	6712	6694	6694
q10	3220	3252	3294	3252
q11	308	194	185	185
q12	348	211	205	205
q13	4587	3809	3819	3809
q14	241	210	215	210
q15	559	522	524	522
q16	446	388	382	382
q17	1001	571	570	570
q18	7260	6879	7033	6879
q19	1516	1353	1435	1353
q20	496	311	318	311
q21	3118	2671	2709	2671
q22	346	278	281	278
Total cold run time: 44442 ms
Total hot run time: 39998 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4351	4343	4395	4343
q2	267	163	172	163
q3	3552	3538	3537	3537
q4	2385	2382	2369	2369
q5	5767	5780	5760	5760
q6	242	120	123	120
q7	2392	1905	1872	1872
q8	3542	3536	3534	3534
q9	9030	9039	9019	9019
q10	3907	4003	3997	3997
q11	486	381	365	365
q12	757	595	591	591
q13	4293	3568	3543	3543
q14	286	265	254	254
q15	569	520	518	518
q16	502	458	448	448
q17	1888	1871	1885	1871
q18	8668	8138	8301	8138
q19	1740	1727	1780	1727
q20	2270	1937	1950	1937
q21	6542	6221	6200	6200
q22	498	404	428	404
Total cold run time: 63934 ms
Total hot run time: 60710 ms

@doris-robot
Copy link

doris-robot commented Dec 20, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.47 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17188265442 Bytes

@doris-robot
Copy link

doris-robot commented Dec 20, 2023

TeamCity be ut coverage result:
Function Coverage: 36.47% (8534/23397)
Line Coverage: 28.61% (69389/242555)
Region Coverage: 27.63% (35907/129950)
Branch Coverage: 24.37% (18353/75306)
Coverage Report: http://coverage.selectdb-in.cc/coverage/14344281303ae3b4fcd8ff250d40974603968801_14344281303ae3b4fcd8ff250d40974603968801/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deardeng @dataroaring
[fix](partition) Comment out some exceptions with partition equal to …
3e3009c 
…0 and return

In some scenarios, the partition id in the table meta is 0, but the rowset meta partition is not 0, (apache#28055) PR check partition id will caused be failed to start when upgrade

meta like this

```
{
    "table_id": 1266302,
    "partition_id": 0,
    "tablet_id": 1289222,
    "schema_hash": 816078096,
    "shard_id": 949,
    "creation_time": 1684805433,
    "cumulative_layer_point": -1,
    "tablet_state": "PB_RUNNING",
    "schema": {
        "keys_type": "DUP_KEYS",
        "column": [
	    ...
        ],
        "num_short_key_columns": 1,
        "num_rows_per_row_block": 1024,
	...
        "skip_write_index_on_load": false
    },
    "rs_metas": [
        {
            "rowset_id": 0,
            "partition_id": 1289193,
            "tablet_id": 1289222,
            "tablet_schema_hash": 816078096,
            "newest_write_timestamp": 1684805433,
	    ...
            "segments_overlap_pb": "NONOVERLAPPING"
        }
    ],
    "in_restore_mode": false,
    "tablet_uid": {
        "hi": -4301918259617109775,
        "lo": 2820124814688031668
    },
    "preferred_rowset_type": "BETA_ROWSET",
    "tablet_type": "TABLET_TYPE_DISK",
    "replica_id": 1812028,
    "enable_unique_key_merge_on_write": false,
    "binlog_config": {
        "enable": false,
        "ttl_seconds": 9223372036854775807,
        "max_bytes": 9223372036854775807,
        "max_history_nums": 9223372036854775807
    },
    "compaction_policy": "size_based",
    "time_series_compaction_goal_size_mbytes": 1024,
    "time_series_compaction_file_count_threshold": 2000,
    "time_series_compaction_time_threshold_seconds": 3600
}
```
@deardeng @dataroaring
fix
3520263
@dataroaring
Copy link
Contributor

dataroaring commented Dec 21, 2023

run buildall

@dataroaring dataroaring mentioned this pull request Dec 21, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

TeamCity be ut coverage result:
Function Coverage: 36.47% (8536/23404)
Line Coverage: 28.59% (69396/242726)
Region Coverage: 27.61% (35907/130044)
Branch Coverage: 24.35% (18350/75348)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3520263c93f610c26068a9c31fd8f05983c729c1_3520263c93f610c26068a9c31fd8f05983c729c1/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 3520263c93f610c26068a9c31fd8f05983c729c1, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4690	4431	4478	4431
q2	367	159	158	158
q3	1473	1281	1248	1248
q4	1115	929	888	888
q5	3174	3172	3159	3159
q6	247	129	127	127
q7	979	501	500	500
q8	2186	2231	2166	2166
q9	6713	6676	6633	6633
q10	3226	3275	3302	3275
q11	312	194	189	189
q12	355	216	215	215
q13	4558	3836	3816	3816
q14	243	218	216	216
q15	576	540	532	532
q16	450	411	395	395
q17	1000	570	546	546
q18	7198	6979	6925	6925
q19	1532	1370	1434	1370
q20	562	329	291	291
q21	3107	2650	2715	2650
q22	363	296	303	296
Total cold run time: 44426 ms
Total hot run time: 40026 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4361	4363	4391	4363
q2	274	171	179	171
q3	3549	3544	3521	3521
q4	2379	2382	2372	2372
q5	5755	5751	5748	5748
q6	243	126	123	123
q7	2400	1837	1910	1837
q8	3533	3538	3544	3538
q9	9014	9036	9011	9011
q10	3932	4025	4014	4014
q11	495	384	381	381
q12	776	622	605	605
q13	4279	3598	3541	3541
q14	295	257	273	257
q15	574	527	529	527
q16	524	486	482	482
q17	1886	1862	1864	1862
q18	8766	8277	8349	8277
q19	1731	1751	1781	1751
q20	2278	1989	1939	1939
q21	6553	6254	6201	6201
q22	510	426	445	426
Total cold run time: 64107 ms
Total hot run time: 60947 ms

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.87 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17183492933 Bytes

yujun777
yujun777 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit d7001ce into apache:master Dec 29, 2023
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@deardeng @HappenLee
[fix](partition) Comment out some exceptions with partition equal to … (
ea1c7b6 
apache#28702)

* [fix](partition) Comment out some exceptions with partition equal to 0 and return

In some scenarios, the partition id in the table meta is 0, but the rowset meta partition is not 0, (apache#28055) PR check partition id will caused be failed to start when upgrade

meta like this

```
{
    "table_id": 1266302,
    "partition_id": 0,
    "tablet_id": 1289222,
    "schema_hash": 816078096,
    "shard_id": 949,
    "creation_time": 1684805433,
    "cumulative_layer_point": -1,
    "tablet_state": "PB_RUNNING",
    "schema": {
        "keys_type": "DUP_KEYS",
        "column": [
	    ...
        ],
        "num_short_key_columns": 1,
        "num_rows_per_row_block": 1024,
	...
        "skip_write_index_on_load": false
    },
    "rs_metas": [
        {
            "rowset_id": 0,
            "partition_id": 1289193,
            "tablet_id": 1289222,
            "tablet_schema_hash": 816078096,
            "newest_write_timestamp": 1684805433,
	    ...
            "segments_overlap_pb": "NONOVERLAPPING"
        }
    ],
    "in_restore_mode": false,
    "tablet_uid": {
        "hi": -4301918259617109775,
        "lo": 2820124814688031668
    },
    "preferred_rowset_type": "BETA_ROWSET",
    "tablet_type": "TABLET_TYPE_DISK",
    "replica_id": 1812028,
    "enable_unique_key_merge_on_write": false,
    "binlog_config": {
        "enable": false,
        "ttl_seconds": 9223372036854775807,
        "max_bytes": 9223372036854775807,
        "max_history_nums": 9223372036854775807
    },
    "compaction_policy": "size_based",
    "time_series_compaction_goal_size_mbytes": 1024,
    "time_series_compaction_file_count_threshold": 2000,
    "time_series_compaction_time_threshold_seconds": 3600
}
```

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deardeng @doris-robot @dataroaring @yujun777 @yiguolei