Skip to content

[Bug](pipeline) try fix the exchange sink buffer result error #27052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Nov 16, 2023
Merged

[Bug](pipeline) try fix the exchange sink buffer result error #27052

yiguolei merged 1 commit into from
Nov 16, 2023

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Nov 15, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Contributor Author

HappenLee commented Nov 15, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 15, 2023

TeamCity be ut coverage result:
Function Coverage: 36.78% (8414/22876)
Line Coverage: 29.27% (68402/233661)
Region Coverage: 27.87% (35355/126842)
Branch Coverage: 24.64% (18068/73318)
Coverage Report: http://coverage.selectdb-in.cc/coverage/963129669ca2aa1bf6b38e2c8a6a35777f974402_963129669ca2aa1bf6b38e2c8a6a35777f974402/report/index.html

@doris-robot
Copy link

doris-robot commented Nov 15, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 963129669ca2aa1bf6b38e2c8a6a35777f974402, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4902	4607	4620	4607
q2	366	165	160	160
q3	2029	1886	1893	1886
q4	1385	1228	1201	1201
q5	3946	3912	3972	3912
q6	245	132	133	132
q7	1364	872	887	872
q8	2740	2772	2754	2754
q9	17916	9675	9583	9583
q10	3456	3518	3518	3518
q11	383	249	236	236
q12	448	284	283	283
q13	4560	3822	3834	3822
q14	325	285	302	285
q15	596	537	536	536
q16	663	577	577	577
q17	1133	966	960	960
q18	7812	7499	7294	7294
q19	1674	1682	1672	1672
q20	581	294	300	294
q21	4404	3932	3946	3932
q22	471	371	373	371
Total cold run time: 61399 ms
Total hot run time: 48887 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4573	4524	4543	4524
q2	328	232	260	232
q3	4002	3979	3959	3959
q4	2694	2677	2677	2677
q5	9855	9755	9717	9717
q6	239	119	125	119
q7	2630	2293	2287	2287
q8	4515	4504	4498	4498
q9	13242	13034	13167	13034
q10	4085	4168	4160	4160
q11	793	684	700	684
q12	978	814	796	796
q13	4277	3585	3575	3575
q14	374	340	370	340
q15	586	518	514	514
q16	744	717	657	657
q17	3915	3827	3831	3827
q18	9620	8926	8925	8925
q19	1812	1793	1758	1758
q20	2388	2067	2058	2058
q21	8759	8663	8627	8627
q22	927	854	813	813
Total cold run time: 81336 ms
Total hot run time: 77781 ms

airborne12
airborne12 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 15, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.72 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17099012729 Bytes

yiguolei
yiguolei approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 7ef1f7e into apache:master Nov 16, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei added usercase Important user case type label dev/2.0.3 and removed approved Indicates a PR has been approved by one committer. labels Nov 16, 2023
@xiaokang xiaokang mentioned this pull request Nov 17, 2023
Merged
yiguolei added a commit that referenced this pull request Nov 17, 2023
@yiguolei
Revert "[Bug](pipeline) try fix the exchange sink buffer result error (…
047ba7a 
…#27052)"

This reverts commit 7ef1f7e.
This was referenced Nov 17, 2023
Closed
Closed
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
@HappenLee @seawinde
[Bug](pipeline) try fix the exchange sink buffer result error (apache…
f8c9399 
…#27052)
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@HappenLee
[Bug](pipeline) try fix the exchange sink buffer result error (apache…
92b16a3 
…#27052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

dev/2.0.3-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HappenLee @doris-robot @airborne12 @yiguolei @xiaokang