Skip to content

[fix](catalog) Fix ClickHouse DataTime64 precision parsing #26977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zy-kkk merged 1 commit into from
Nov 15, 2023
Merged

[fix](catalog) Fix ClickHouse DataTime64 precision parsing #26977

zy-kkk merged 1 commit into from
Nov 15, 2023

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 14, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 14, 2023

run buildall

morningman
morningman approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk mentioned this pull request Nov 14, 2023
Merged
@doris-robot
Copy link

doris-robot commented Nov 14, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.36 seconds
stream load tsv: 549 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17098032152 Bytes

@doris-robot
Copy link

doris-robot commented Nov 14, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit f77ee569316975f36ffa5f4789956c38297b639a, data reload: false

run tpch-sf100 query with default conf and session variables
q1	5279	5149	5131	5131
q2	353	159	160	159
q3	2073	2009	1976	1976
q4	1412	1359	1370	1359
q5	4019	3952	4013	3952
q6	255	134	131	131
q7	1487	891	899	891
q8	2798	2791	2776	2776
q9	9756	9590	9593	9590
q10	3442	3548	3541	3541
q11	391	261	254	254
q12	434	287	292	287
q13	4608	4097	4106	4097
q14	329	295	290	290
q15	601	552	535	535
q16	688	594	583	583
q17	1136	1082	1097	1082
q18	8036	7525	7677	7525
q19	1680	1682	1707	1682
q20	591	308	326	308
q21	4691	4321	4389	4321
q22	513	419	404	404
Total cold run time: 54572 ms
Total hot run time: 50874 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	5105	5042	5100	5042
q2	335	228	257	228
q3	4052	4058	4032	4032
q4	2784	2810	2779	2779
q5	9794	9772	9696	9696
q6	247	123	121	121
q7	3059	2546	2506	2506
q8	4810	4867	4830	4830
q9	13258	13215	13211	13211
q10	4097	4181	4192	4181
q11	773	653	677	653
q12	983	819	839	819
q13	4289	3903	3849	3849
q14	382	336	344	336
q15	604	550	541	541
q16	765	695	677	677
q17	3942	3920	3783	3783
q18	9593	9449	9360	9360
q19	1838	1774	1789	1774
q20	2421	2086	2071	2071
q21	9020	8774	8809	8774
q22	913	856	835	835
Total cold run time: 83064 ms
Total hot run time: 80098 ms

LemonLiTree
LemonLiTree approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@LemonLiTree LemonLiTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zy-kkk zy-kkk merged commit df867a1 into apache:master Nov 15, 2023
@zy-kkk zy-kkk deleted the add_ck_case branch November 15, 2023 02:23
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 15, 2023
@zy-kkk @seawinde
[fix](catalog) Fix ClickHouse DataTime64 precision parsing (apache#26977
e5a436c 
)
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@zy-kkk
[fix](catalog) Fix ClickHouse DataTime64 precision parsing (apache#26977
0345da3 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@LemonLiTree LemonLiTree LemonLiTree approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zy-kkk @doris-robot @morningman @LemonLiTree