Skip to content

Revert "[Coverage](BE) Delete vinfo_func in BE" #26723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 1 commit into from
Nov 10, 2023
Merged

Revert "[Coverage](BE) Delete vinfo_func in BE" #26723

zhangstar333 merged 1 commit into from
Nov 10, 2023

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Nov 9, 2023

Reverts #26562

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 9, 2023

run buildall

github-actions[bot]
github-actions bot reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/exprs/vinfo_func.cpp

#include <gen_cpp/Exprs_types.h>
#include <glog/logging.h>
#include <stddef.h>
Copy link
Contributor

@github-actions github-actions bot Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]

Suggested change
#include <stddef.h>
#include <cstddef>

be/src/vec/exprs/vinfo_func.cpp
Comment on lines +35 to +36
namespace doris {
namespace vectorized {
Copy link
Contributor

@github-actions github-actions bot Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]

Suggested change
namespace doris {
namespace vectorized {
namespace doris::vectorized {

be/src/vec/exprs/vinfo_func.cpp:37:

- } // namespace vectorized
- } // namespace doris
+ } // namespace doris

@doris-robot
Copy link

doris-robot commented Nov 9, 2023

TeamCity be ut coverage result:
Function Coverage: 36.74% (8396/22851)
Line Coverage: 29.26% (68111/232808)
Region Coverage: 27.90% (35226/126278)
Branch Coverage: 24.71% (18017/72926)
Coverage Report: http://coverage.selectdb-in.cc/coverage/66b20bb0133fb0be9422f31f79a6c831254a6ab0_66b20bb0133fb0be9422f31f79a6c831254a6ab0/report/index.html

@doris-robot
Copy link

doris-robot commented Nov 9, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 66b20bb0133fb0be9422f31f79a6c831254a6ab0, data reload: false

run tpch-sf100 query with default conf and session variables
q1	5230	5012	5062	5012
q2	370	175	201	175
q3	2087	2085	2079	2079
q4	1497	1406	1453	1406
q5	4139	4141	4087	4087
q6	257	130	135	130
q7	2067	1604	1649	1604
q8	2768	2754	2754	2754
q9	10497	10273	10323	10273
q10	3495	3576	3569	3569
q11	378	259	260	259
q12	448	297	294	294
q13	4556	4173	4106	4106
q14	340	296	286	286
q15	621	559	555	555
q16	703	619	600	600
q17	1155	1092	1100	1092
q18	7711	7426	7414	7414
q19	1704	1726	1706	1706
q20	620	361	361	361
q21	4925	4596	4578	4578
q22	524	438	428	428
Total cold run time: 56092 ms
Total hot run time: 52768 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4988	4946	5289	4946
q2	330	238	250	238
q3	4109	3969	3917	3917
q4	2795	2742	2730	2730
q5	6526	6451	6514	6451
q6	246	124	124	124
q7	3154	2747	2665	2665
q8	4781	4787	4790	4787
q9	17730	17799	17775	17775
q10	4092	4150	4160	4150
q11	773	672	647	647
q12	1019	864	833	833
q13	4275	3903	3894	3894
q14	383	350	352	350
q15	659	584	563	563
q16	757	736	715	715
q17	3902	3933	3879	3879
q18	9274	9173	9286	9173
q19	1923	1800	1795	1795
q20	2390	2054	2026	2026
q21	8915	8737	8658	8658
q22	972	872	867	867
Total cold run time: 83993 ms
Total hot run time: 81183 ms

@doris-robot
Copy link

doris-robot commented Nov 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.49 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162185874 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023

PR approved by anyone and no changes requested.

@zhangstar333 zhangstar333 merged commit 2bf48d7 into apache:master Nov 10, 2023
@zclllyybb zclllyybb deleted the revert-26562-delete_info branch November 10, 2023 02:15
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@zclllyybb @seawinde
Revert "[Coverage](BE) Delete vinfo_func in BE (apache#26562)" (apach…
88d9d9d 
…e#26723)

This reverts commit 01094fd.
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@zclllyybb
Revert "[Coverage](BE) Delete vinfo_func in BE (apache#26562)" (apach…
9d9b0eb 
…e#26723)

This reverts commit 01094fd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zclllyybb @doris-robot @BiteTheDDDDt @zhangstar333