Skip to content

[Fix](orc-reader) Add missing break introduced by #26548. #26633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 9, 2023
Merged

[Fix](orc-reader) Add missing break introduced by #26548. #26633

morningman merged 1 commit into from
Nov 9, 2023

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Nov 9, 2023

Proposed changes

Add missing break introduced by #26548. Sorry for this mistake.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@kaka11chen
Copy link
Contributor Author

kaka11chen commented Nov 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 9, 2023

TeamCity be ut coverage result:
Function Coverage: 36.75% (8401/22861)
Line Coverage: 29.25% (68121/232921)
Region Coverage: 27.90% (35222/126262)
Branch Coverage: 24.70% (18003/72872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ab0f3e4d3ac72edbcc55e76feae14b60bf650079_ab0f3e4d3ac72edbcc55e76feae14b60bf650079/report/index.html

morningman
morningman approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 9, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit ab0f3e4d3ac72edbcc55e76feae14b60bf650079, data reload: false

run tpch-sf100 query with default conf and session variables
q1	5292	5090	5056	5056
q2	376	247	231	231
q3	2053	2030	2053	2030
q4	1467	1441	1409	1409
q5	4090	4126	4111	4111
q6	252	134	136	134
q7	2062	1615	1601	1601
q8	2739	2721	2719	2719
q9	10483	10316	10285	10285
q10	3479	3582	3568	3568
q11	380	254	256	254
q12	454	284	293	284
q13	4475	4092	4072	4072
q14	316	293	290	290
q15	630	560	584	560
q16	701	627	603	603
q17	1132	1055	1075	1055
q18	7828	7394	7372	7372
q19	1687	1671	1707	1671
q20	585	367	372	367
q21	4899	4520	4566	4520
q22	532	423	445	423
Total cold run time: 55912 ms
Total hot run time: 52615 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4961	5017	5035	5017
q2	352	245	275	245
q3	4227	3920	4017	3920
q4	2846	2796	2810	2796
q5	6459	6362	6401	6362
q6	241	124	126	124
q7	3139	2740	2700	2700
q8	4779	4726	4679	4679
q9	17910	17630	17821	17630
q10	4110	4190	4218	4190
q11	718	635	666	635
q12	1013	823	806	806
q13	4301	3905	3830	3830
q14	381	358	350	350
q15	640	565	555	555
q16	787	674	716	674
q17	3931	3913	3880	3880
q18	9678	9666	9624	9624
q19	1903	1750	1742	1742
q20	2388	2093	2069	2069
q21	8902	8822	8721	8721
q22	988	882	852	852
Total cold run time: 84654 ms
Total hot run time: 81401 ms

@doris-robot
Copy link

doris-robot commented Nov 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.43 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162448232 Bytes

@morningman morningman merged commit c07a70e into apache:master Nov 9, 2023
@kaka11chen kaka11chen mentioned this pull request Nov 10, 2023
Merged
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@kaka11chen @seawinde
[Fix](orc-reader) Add missing break introduced by apache#26548. (ap…
019ad66 
…ache#26633)

Add missing break introduced by apache#26548. Sorry for this mistake.
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Closed
@Yulei-Yang Yulei-Yang mentioned this pull request Dec 5, 2023
Closed
3 tasks
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@kaka11chen
[Fix](orc-reader) Add missing break introduced by apache#26548. (ap…
9549111 
…ache#26633)

Add missing break introduced by apache#26548. Sorry for this mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@AshinGau AshinGau AshinGau approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_c reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaka11chen @doris-robot @morningman @AshinGau @wm1581066