Skip to content

Conversation

@zfr9527
Copy link
Contributor

@zfr9527 zfr9527 commented Nov 7, 2023

Proposed changes

fix nested data type to create table

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@amorynan
Copy link
Contributor

amorynan commented Nov 7, 2023

run buildall

Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor

amorynan commented Nov 7, 2023

run buildall

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


if (typeArr.size() != maxDepth) {
println("level not equal typeArr")
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual calls to the old code would have made errors, and the current code is guaranteed not to make errors here

"c_char", "c_varchar", "c_string"]
def complexDataTypeArr = ["array", "map", "struct"]
// def tbName = "test"
def baseStructScala = "col1:int(11),col2:tinyint(4),col3:smallint(6),col4:boolean,col5:bigint(20),col6:largeint(40)," +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use cross-line string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been modified

@xiaokang
Copy link
Contributor

xiaokang commented Nov 7, 2023

run buildall

xiaokang
xiaokang previously approved these changes Nov 7, 2023
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR approved by at least one committer and no changes requested.

@xiaokang
Copy link
Contributor

xiaokang commented Nov 7, 2023

run buildall

@xiaokang
Copy link
Contributor

xiaokang commented Nov 8, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 8, 2023
@zfr9527 zfr9527 force-pushed the nested_type_zfr_1 branch 2 times, most recently from 7d8a24d to baa0ce9 Compare November 8, 2023 14:52
@amorynan
Copy link
Contributor

amorynan commented Nov 9, 2023

run buildall

Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants