-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nestedType)fix nested data type to create table #26506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
105ef43 to
11b9018
Compare
|
run buildall |
amorynan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
11b9018 to
ca27a46
Compare
|
run buildall |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| if (typeArr.size() != maxDepth) { | ||
| println("level not equal typeArr") | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual calls to the old code would have made errors, and the current code is guaranteed not to make errors here
| "c_char", "c_varchar", "c_string"] | ||
| def complexDataTypeArr = ["array", "map", "struct"] | ||
| // def tbName = "test" | ||
| def baseStructScala = "col1:int(11),col2:tinyint(4),col3:smallint(6),col4:boolean,col5:bigint(20),col6:largeint(40)," + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use cross-line string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have been modified
0af52f9 to
9d5060d
Compare
|
run buildall |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
9d5060d to
b1ccbd6
Compare
|
run buildall |
b1ccbd6 to
6f9f10f
Compare
|
run buildall |
6f9f10f to
5fc4fb3
Compare
7d8a24d to
baa0ce9
Compare
baa0ce9 to
f372682
Compare
|
run buildall |
amorynan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
fix nested data type to create table
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...