Skip to content

Conversation

@Nitin-Kashyap
Copy link
Contributor

@Nitin-Kashyap Nitin-Kashyap commented Oct 6, 2023

Proposed changes

  1. Add queries view as table function.
  2. Proxy result to other FEs and return merged results back to BE.

Issue Number: close #25051

image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 9, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@Nitin-Kashyap Nitin-Kashyap requested a review from yiguolei October 9, 2023 05:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 9, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.31% (8149/22443)
Line Coverage: 28.44% (65167/229170)
Region Coverage: 27.37% (33768/123394)
Branch Coverage: 24.04% (17205/71564)
Coverage Report: http://coverage.selectdb-in.cc/coverage/18b3ac0324db05fbb68ec2097d1c0031c23c2280_18b3ac0324db05fbb68ec2097d1c0031c23c2280/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.23 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162285897 Bytes

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 10, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.28% (8149/22461)
Line Coverage: 28.42% (65177/229296)
Region Coverage: 27.35% (33773/123482)
Branch Coverage: 24.03% (17208/71620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e0c5eabe0d60c4fde96a31435993bc2dc6f73524_e0c5eabe0d60c4fde96a31435993bc2dc6f73524/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.73 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162305550 Bytes

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 10, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 10, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 10, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 11, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 11, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Nitin-Kashyap added a commit to Nitin-Kashyap/doris that referenced this pull request Oct 11, 2023
1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor

run buildall

@yiguolei
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.22% (8154/22510)
Line Coverage: 28.34% (65285/230391)
Region Coverage: 27.05% (33810/124985)
Branch Coverage: 23.88% (17250/72234)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7eed37ff2dda03e45f8515ff52ec05689d0f6a8a_7eed37ff2dda03e45f8515ff52ec05689d0f6a8a/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.17 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162077919 Bytes

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit bdb64ea into apache:master Oct 12, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…he#25052)

1. Add queries view as table function.
2. Proxy result to other FEs and return merged results back to BE.

Co-authored-by: yiguolei <676222867@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Running Queries as table valued function

4 participants