Skip to content

[fix](nereids)don't build cte producer if the consumer is empty relation #21317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 5 commits into from
Jul 7, 2023
Merged

[fix](nereids)don't build cte producer if the consumer is empty relation #21317

morrySnow merged 5 commits into from
Jul 7, 2023

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Jun 29, 2023

Proposed changes

explain WITH cte_0 AS ( SELECT 1 AS a ) SELECT * from cte_0 t1 join cte_0 t2 on true WHERE false;
before:

+----------------------------+
| Explain String             |
+----------------------------+
| PLAN FRAGMENT 0            |
|   OUTPUT EXPRS:            |
|     a[#1]                  |
|     a[#2]                  |
|   PARTITION: UNPARTITIONED |
|                            |
|   VRESULT SINK             |
|                            |
|   1:VEMPTYSET              |
|                            |
| PLAN FRAGMENT 1            |
|   OUTPUT EXPRS:            |
|     a[#0]                  |
|   PARTITION: UNPARTITIONED |
|                            |
|   MultiCastDataSinks       |
|                            |
|   0:VUNION                 |
|      constant exprs:       |
|          1                 |
+----------------------------+

after:

+----------------------------+
| Explain String             |
+----------------------------+
| PLAN FRAGMENT 0            |
|   OUTPUT EXPRS:            |
|     a[#0]                  |
|     a[#1]                  |
|   PARTITION: UNPARTITIONED |
|                            |
|   VRESULT SINK             |
|                            |
|   0:VEMPTYSET              |
+----------------------------+

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999
Copy link
Contributor Author

starocean999 commented Jun 29, 2023

run buildall

@morrySnow morrySnow added the dev/2.0.0 2.0.0 release label Jun 30, 2023
morrySnow
morrySnow previously approved these changes Jun 30, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 3, 2023
@starocean999
Copy link
Contributor Author

starocean999 commented Jul 3, 2023

run buildall

2 similar comments
@starocean999
Copy link
Contributor Author

starocean999 commented Jul 3, 2023

run buildall

@starocean999
Copy link
Contributor Author

starocean999 commented Jul 3, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 3, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.51 seconds
stream load tsv: 461 seconds loaded 74807831229 Bytes, about 154 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 57 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select: 68.5 seconds inserted 10000000 Rows, about 145K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230703051503_clickbench_pr_171151.html

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 3, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.43 seconds
stream load tsv: 461 seconds loaded 74807831229 Bytes, about 154 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 57 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select: 69.8 seconds inserted 10000000 Rows, about 143K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230703054110_clickbench_pr_171181.html

morrySnow
morrySnow previously approved these changes Jul 4, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 4, 2023
@starocean999
Copy link
Contributor Author

starocean999 commented Jul 4, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 5, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.18 seconds
stream load tsv: 458 seconds loaded 74807831229 Bytes, about 155 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 56 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select: 70.7 seconds inserted 10000000 Rows, about 141K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230705031912_clickbench_pr_172423.html

@starocean999
Copy link
Contributor Author

starocean999 commented Jul 6, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 6, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.28 seconds
stream load tsv: 499 seconds loaded 74807831229 Bytes, about 142 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 88.1 seconds inserted 10000000 Rows, about 113K ops/s
storage size: 17162225283 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706162416_clickbench_pr_173531.html

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 6, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.21 seconds
stream load tsv: 442 seconds loaded 74807831229 Bytes, about 161 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 56 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select: 68.6 seconds inserted 10000000 Rows, about 145K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706085227_clickbench_pr_173529.html

morrySnow
morrySnow previously approved these changes Jul 6, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 6, 2023
@starocean999
Copy link
Contributor Author

starocean999 commented Jul 6, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 6, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 55.87 seconds
stream load tsv: 502 seconds loaded 74807831229 Bytes, about 142 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 88.5 seconds inserted 10000000 Rows, about 112K ops/s
storage size: 17162543215 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706212113_clickbench_pr_173819.html

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 6, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.24 seconds
stream load tsv: 449 seconds loaded 74807831229 Bytes, about 158 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 56 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select: 67.7 seconds inserted 10000000 Rows, about 147K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706133337_clickbench_pr_173825.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit d39bca5 into apache:master Jul 7, 2023
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 9, 2023
xiaokang pushed a commit that referenced this pull request Jul 9, 2023
@starocean999 @xiaokang
[fix](nereids) don't build cte producer if the consumer is empty rela…
aa4ad7b 
…tion (#21317)

explain WITH cte_0 AS ( SELECT 1 AS a ) SELECT * from cte_0 t1 join cte_0 t2 on true WHERE false;
before:
```
+----------------------------+
| Explain String             |
+----------------------------+
| PLAN FRAGMENT 0            |
|   OUTPUT EXPRS:            |
|     a[#1]                  |
|     a[#2]                  |
|   PARTITION: UNPARTITIONED |
|                            |
|   VRESULT SINK             |
|                            |
|   1:VEMPTYSET              |
|                            |
| PLAN FRAGMENT 1            |
|   OUTPUT EXPRS:            |
|     a[#0]                  |
|   PARTITION: UNPARTITIONED |
|                            |
|   MultiCastDataSinks       |
|                            |
|   0:VUNION                 |
|      constant exprs:       |
|          1                 |
+----------------------------+
```
after:

```
+----------------------------+
| Explain String             |
+----------------------------+
| PLAN FRAGMENT 0            |
|   OUTPUT EXPRS:            |
|     a[#0]                  |
|     a[#1]                  |
|   PARTITION: UNPARTITIONED |
|                            |
|   VRESULT SINK             |
|                            |
|   0:VEMPTYSET              |
+----------------------------+
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@sohardforaname sohardforaname sohardforaname approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/nereids dev/2.0.0-merged kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@starocean999 @hello-stephen @sohardforaname @morrySnow @xiaokang