[Fix](Planner)fix NPE msg when parse error. #19097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
CalvinKirs
approved these changes
Apr 26, 2023
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morrySnow
approved these changes
Apr 26, 2023
Contributor
|
PR approved by at least one committer and no changes requested. |
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
some syntax error will cause unclear msg: NPE，because symbol.value is null and cause NPE when call toLowerCase(), we fix it by check if the value is null and return early.
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Apr 28, 2023
some syntax error will cause unclear msg: NPE，because symbol.value is null and cause NPE when call toLowerCase(), we fix it by check if the value is null and return early.
morningman
pushed a commit
that referenced
this pull request
Apr 30, 2023
some syntax error will cause unclear msg: NPE，because symbol.value is null and cause NPE when call toLowerCase(), we fix it by check if the value is null and return early.
Reminiscent
pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
some syntax error will cause unclear msg: NPE，because symbol.value is null and cause NPE when call toLowerCase(), we fix it by check if the value is null and return early.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
some syntax error will cause unclear msg: NPE，because symbol.value is null and cause NPE when call toLowerCase(), we fix it by check if the value is null and return early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
some syntax error will cause unclear msg: NPE，because symbol.value is null and cause NPE when call toLowerCase(), we fix it by check if the value is null and return early.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...