Skip to content

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Mar 29, 2023

Proposed changes

Issue Number: close #xxx
#18171

Problem summary

  1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
  2. TableFunctionNode should use child node's output tuple id as the input tuple id

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Mar 29, 2023
@zy-kkk zy-kkk added usercase Important user case type label dev/1.2.4 labels Mar 29, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 30, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit b365795 into apache:master Mar 30, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
…efIds (apache#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
…efIds (apache#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
…efIds (apache#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
morningman pushed a commit that referenced this pull request Apr 3, 2023
…efIds (#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
luwei16 pushed a commit to luwei16/incubator-doris that referenced this pull request Apr 7, 2023
…f's id into TableRef's allTableRefIds (apache#18220)" (apache#1573)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id

Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
morningman pushed a commit to morningman/doris that referenced this pull request Apr 9, 2023
…efIds (apache#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…efIds (apache#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…efIds (apache#18220)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
…TableRefIds (apache#18220)" (apache#1574)

1. add LateralViewRef's id into TableRef's allTableRefIds, so the caller won't miss LateralViewRef when trying to get all the tableref ids.
2. TableFunctionNode should use child node's output tuple id as the input tuple id

Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/1.2.4-merged kind/test reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants