Skip to content

[fix](coalesce) fix problem that coalesce function may cause problem of block mem reuse #17940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 25, 2023
Merged

[fix](coalesce) fix problem that coalesce function may cause problem of block mem reuse #17940

dataroaring merged 1 commit into from
Mar 25, 2023

Conversation

@jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Mar 20, 2023

Proposed changes

Issue Number: close #17588

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Mar 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

jacktengg commented Mar 20, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 20, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.93 seconds
stream load tsv: 455 seconds loaded 74807831229 Bytes, about 156 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230321075736_clickbench_pr_117851.html

@jacktengg
Copy link
Contributor Author

jacktengg commented Mar 20, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

jacktengg commented Mar 21, 2023

run buildall

@jacktengg
Copy link
Contributor Author

jacktengg commented Mar 21, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

jacktengg commented Mar 24, 2023

run buildall

yiguolei
yiguolei approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei added usercase Important user case type label dev/1.2.4 and removed dev/1.2.3 labels Mar 24, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 193ae35 into apache:master Mar 25, 2023
morningman pushed a commit that referenced this pull request Mar 28, 2023
@jacktengg @morningman
[fix](coalesce) fix problem that coalesce function may cause problem …
d3a1bad 
…of block mem reuse (#17940)
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@jacktengg @gnehil
[fix](coalesce) fix problem that coalesce function may cause problem …
d9514b9 
…of block mem reuse (apache#17940)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
@jacktengg
[fix](coalesce) fix problem that coalesce function may cause problem …
5002f4f 
…of block mem reuse (apache#17940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/1.2.4-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] coalesce should return a column with copied data

5 participants

@jacktengg @hello-stephen @yiguolei @morningman @dataroaring