Skip to content

Conversation

@sohardforaname
Copy link
Contributor

@sohardforaname sohardforaname commented Mar 15, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Mar 15, 2023
@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 15, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.94 seconds
stream load tsv: 467 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 26 seconds loaded 2358488459 Bytes, about 86 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230323051119_clickbench_pr_119300.html

@morrySnow morrySnow added dev/1.1.6 dev/1.2.3 usercase Important user case type label labels Mar 15, 2023
@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run fe ut

1 similar comment
@sohardforaname
Copy link
Contributor Author

run fe ut

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run fe ut

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run p0

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run p0

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run fe ut

2 similar comments
@sohardforaname
Copy link
Contributor Author

run fe ut

@sohardforaname
Copy link
Contributor Author

run fe ut

@sohardforaname
Copy link
Contributor Author

run buildall

1 similar comment
@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run p0

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit aa3ea4b into apache:master Mar 24, 2023
morningman pushed a commit that referenced this pull request Mar 28, 2023
fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.
luwei16 added a commit to luwei16/incubator-doris that referenced this pull request Apr 7, 2023
…pache#17815)" (apache#1591)

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

Co-authored-by: mch_ucchi <41606806+sohardforaname@users.noreply.github.com>
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…#17815)

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…#17815)

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.
swjtu-zhanglei pushed a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
…pache#17815)" (apache#1592)

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

Co-authored-by: mch_ucchi <41606806+sohardforaname@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/1.1.6 dev/1.2.4-merged kind/test reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants