Add check for to_bitmap function argument #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Sep 4, 2019
be/src/exec/base_scanner.cpp
Outdated
| int dest_index = ctx_idx++; | ||
| ExprContext* ctx = _dest_expr_ctx[dest_index]; | ||
| void* value = ctx->get_value(_src_tuple_row); | ||
| std::string expr_error = ctx->get_error_msg(); |
Contributor
There was a problem hiding this comment.
Can we do this when value == nullptr? In this way, we can avoid doing this check in most cases
Contributor
Author
There was a problem hiding this comment.
Update.
I also considered this pointer yesterday, but I found not all UDF return value is null when it set error msg to FunctionContext, but we could make all UDF used in data load follow
this convention.
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Fix issue http://39.106.86.136:8090/browse/CORE-2019 * Hard code to fix wrong column type string generated by FE * [Improve](dynamic table) ensure all columns at schema_version should be persisted to rowset meta In some scenarios, some rowset meta with the same schema version may lose some columns: Eg. Load1 -> version(10) with schema [a, b, c, d, e] Load2 -> version(10) with schema [a, b, c] and has no extended columns Load2 will persist meta with [a, b, c] but Load1 will persist meta with [a, b, c, d, d] * Check columns after sorted by unique id --------- Co-authored-by: Gavin Chou <gavineaglechou@gmail.com> Co-authored-by: eldenmoon <15605149486@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1746
1 Add invalid_argument and out_of_range check for to_bitmap function
2 change the RoaringBitmap single value type to uint32_t
For the following data:
The response of
cat data | curl --location-trusted -u xxx:xxx -H "columns: id,id2, id2=to_bitmap(id2)" -T - http://xxx:8410/api/test/bitmap_test/_stream_loadis :The error log is: