Added MIN/MAX aggregate function compatible with char/varchar #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
requested changes
Sep 3, 2019
| struct AggregateFuncTraits<OLAP_FIELD_AGGREGATION_MIN, OLAP_FIELD_TYPE_VARCHAR> : | ||
| public AggregateFuncTraits<OLAP_FIELD_AGGREGATION_NONE, OLAP_FIELD_TYPE_VARCHAR> { | ||
| static void update(RowCursorCell* dst, const RowCursorCell& src, Arena* arena) { | ||
| bool src_null = src.is_null(); |
Contributor
There was a problem hiding this comment.
I think is dst is null, you can just return, because null is the mimimum value.
Contributor
Author
There was a problem hiding this comment.
We want to ignore null for comparison. We want null to be always replaced.
|
|
||
| Slice* dst_slice = reinterpret_cast<Slice*>(dst->mutable_cell_ptr()); | ||
| const Slice* src_slice = reinterpret_cast<const Slice*>(src.cell_ptr()); | ||
| if (dst_null || src_slice->compare(*dst_slice) < 0) { |
Contributor
There was a problem hiding this comment.
I this this if condition should be:
if (!dst_null && src_slice->compare(*dst_slice) < 0)
Did I misunderstand?
Contributor
Author
There was a problem hiding this comment.
Same here. Null always be replaced.
morningman
approved these changes
Sep 4, 2019
| struct AggregateFuncTraits<OLAP_FIELD_AGGREGATION_MIN, OLAP_FIELD_TYPE_VARCHAR> : | ||
| public AggregateFuncTraits<OLAP_FIELD_AGGREGATION_NONE, OLAP_FIELD_TYPE_VARCHAR> { | ||
| static void update(RowCursorCell* dst, const RowCursorCell& src, Arena* arena) { | ||
| bool src_null = src.is_null(); |
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…n of DECIMAL (apache#1739) FE saves DECIMALV2 as DECIMALV2, however BE saves DECIMALV2 as DECIMAL http://jira.selectdb-in.cc/browse/CORE-2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.