Unify the msg of 'Memory exceed limit' #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new msg of limit exceed: "Memory exceed limit. %msg, Backend:%ip, fragment:%id Used:% , Limit:%. xxx". This commit unifies the msg of 'Memory exceed limit' such as check_query_state, RETURN_IF_LIMIT_EXCEEDED and LIMIT_EXCEEDED.
imay
requested changes
Sep 2, 2019
be/src/exec/sort_node.cpp
Outdated
| "Sort node was getting next from the child."); | ||
| std::stringstream msg; | ||
| msg << "Sort, while getting next from the child."; | ||
| RETURN_IF_LIMIT_EXCEEDED(state, msg.str()); |
Contributor
There was a problem hiding this comment.
Suggested change
| RETURN_IF_LIMIT_EXCEEDED(state, msg.str()); | |
| RETURN_IF_LIMIT_EXCEEDED(state, "Sort, while getting next from the child."); |
| RETURN_IF_ERROR(state->check_query_state()); | ||
| std::stringstream msg; | ||
| msg << "Partitioned aggregation, while getting next from child 0."; | ||
| RETURN_IF_ERROR(state->check_query_state(msg.str())); |
Contributor
There was a problem hiding this comment.
Suggested change
| RETURN_IF_ERROR(state->check_query_state(msg.str())); | |
| RETURN_IF_ERROR(state->check_query_state("Partitioned aggregation, while getting next from child 0.")); |
| if (_status.ok()) { | ||
| if (status.is_mem_limit_exceeded()) { | ||
| _runtime_state->set_mem_limit_exceeded(); | ||
| _runtime_state->set_mem_limit_exceeded(status.get_error_msg()); |
Contributor
There was a problem hiding this comment.
Suggested change
| _runtime_state->set_mem_limit_exceeded(status.get_error_msg()); | |
| _runtime_state->set_mem_limit_exceeded(status.to_string()); |
Contributor
Author
There was a problem hiding this comment.
set_mem_limit_exceeded already set the code of MemoryLimitExceeded
| } | ||
| std::stringstream msg; | ||
| msg << "Buffered block mgr, while getting new block"; | ||
| RETURN_IF_LIMIT_EXCEEDED(_state, msg.str()); |
imay
approved these changes
Sep 3, 2019
Closed
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new msg of limit exceed: "Memory exceed limit. %msg, Backend:%ip, fragment:%id Used:% , Limit:%. xxx".
This commit unifies the msg of 'Memory exceed limit' such as check_query_state, RETURN_IF_LIMIT_EXCEEDED and LIMIT_EXCEEDED.