Add exchange in MemPool to reduce alloc/free operation #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR seems have a indent issue? |
Contributor
Author
Origin code is 2 spaces indent, I change it to 4 spaces which is consistent with most of our code |
kangkaisen
reviewed
Sep 2, 2019
be/src/runtime/mem_pool.cpp
Outdated
| const int MemPool::MAX_CHUNK_SIZE; | ||
|
|
||
| const char* MemPool::LLVM_CLASS_NAME = "class.impala::MemPool"; | ||
| const char* MemPool::LLVM_CLASS_NAME = "class.palo::MemPool"; |
Contributor
|
+1. LGTM. |
chaoyli
approved these changes
Sep 2, 2019
Closed
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…o k2 in expected exception message (apache#1732) close http://jira.selectdb-in.cc/browse/CORE-1943 related to apache#1565 apache#1588 apache#1589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will reuse allocated chunks when storage read operation.
#1726