[fix](struct-type) fix be core when load array orc file #16978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
cambyzju
reviewed
Feb 21, 2023
xy720
reviewed
Feb 21, 2023
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xy720
reviewed
Feb 21, 2023
be/src/runtime/types.cpp
Outdated
| void TypeDescriptor::add_sub_type(TypeDescriptor&& sub_type, std::string&& field_name, | ||
| bool&& is_nullable) { | ||
| children.emplace_back(sub_type); | ||
| if (!field_name.empty()) { |
Member
There was a problem hiding this comment.
Better use a new method add_field_name for field_name.
Because field_name is only used for struct type.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
run buildall |
Merged
5 tasks
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
* fix be core when load array orc file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #16925
Problem summary
in be/src/vec/data_types/data_type_factory.cpp:168, col_desc.contains_nulls[0] memory access out of bounds
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...