Skip to content

[fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance #16889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 22, 2023
Merged

[fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance #16889

dataroaring merged 1 commit into from
Feb 22, 2023

Conversation

@platoneko
Copy link
Contributor

@platoneko platoneko commented Feb 17, 2023 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Problem summary

tablet which has different replica_id from clone req in _do_clone may be a dropped replica in FE, e.g:
BE1 migrates replica of tablet_1 to BE2, but before BE1 drop this replica, another new replica of tablet_1 is migrated to BE1.
We MUST NOT allow to clone success on dropped replica, otherwise replica id may never be consistent between FE and BE, which may affect operations that depend on the replica id (i.e. drop tablet, cooldown).
Also, when FE tries to add replica in handling tabletReport, it MUST create new Replica with replicaId reported by BE to maintain replica meta consistent between FE and BE.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

clang-tidy review says "All clean, LGTM! 👍"

@platoneko platoneko force-pushed the fix-incorrect-replica_id branch from 3c742fb to 6150cef Compare February 17, 2023 14:08
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

clang-tidy review says "All clean, LGTM! 👍"

@platoneko
Copy link
Contributor Author

platoneko commented Feb 20, 2023

run p0

@platoneko platoneko force-pushed the fix-incorrect-replica_id branch from 6150cef to 9729b0e Compare February 20, 2023 13:53
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 20, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.96 seconds
stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230221104027_clickbench_pr_101034.html

@platoneko
Copy link
Contributor Author

platoneko commented Feb 20, 2023

run feut

@platoneko
Copy link
Contributor Author

platoneko commented Feb 20, 2023

run buildall

@platoneko
Copy link
Contributor Author

platoneko commented Feb 20, 2023

build p0

@platoneko
Copy link
Contributor Author

platoneko commented Feb 20, 2023

build feut

@platoneko
Copy link
Contributor Author

platoneko commented Feb 21, 2023

run buildall

@platoneko
Copy link
Contributor Author

platoneko commented Feb 21, 2023 •
edited
Loading

run clickbench

@platoneko
Copy link
Contributor Author

platoneko commented Feb 21, 2023

run p0

dataroaring
dataroaring approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 66ceab5 into apache:master Feb 22, 2023
@morningman morningman added usercase Important user case type label dev/1.2.3-merged and removed dev/1.2.3 labels Feb 23, 2023
morningman pushed a commit that referenced this pull request Feb 23, 2023
@platoneko @morningman
[fix](replica) Fix inconsistent replica id between BE and FE in corne…
783c7d3 
…r case of tablet rebalance (#16889)
@liaoxin01 liaoxin01 mentioned this pull request Mar 3, 2023
Merged
5 tasks
platoneko added a commit to platoneko/doris that referenced this pull request Mar 3, 2023
@platoneko
Revert "[fix](replica) Fix inconsistent replica id between BE and FE …
c472af3 
…in corner case of tablet rebalance (apache#16889)"

This reverts commit 783c7d3.
yiguolei pushed a commit that referenced this pull request Mar 3, 2023
@platoneko
Revert "[fix](replica) Fix inconsistent replica id between BE and FE …
ad93972 
…in corner case of tablet rebalance (#16889)" (#17386)

This reverts commit 783c7d3.
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@platoneko @yagagagaga
[fix](replica) Fix inconsistent replica id between BE and FE in corne…
6b35b41 
…r case of tablet rebalance (apache#16889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.3-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@platoneko @hello-stephen @dataroaring @morningman