Fix time zone compatibility #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to time-zone-be-function Conflicts: be/src/exprs/timestamp_functions.cpp be/test/exprs/timestamp_functions_test.cpp fe/src/main/java/org/apache/doris/qe/Coordinator.java
…to time-zone-be-function
imay
requested changes
Aug 13, 2019
| // String containing a timestamp set as the current time. | ||
| 1: required string now_string | ||
| 2: optional string time_zone | ||
| 2: optional i64 timestamp |
Contributor
There was a problem hiding this comment.
Add some comments to describe timestamp and now_string's relation
Suggested change
| 2: optional i64 timestamp | |
| 2: optional i64 timestamp_ms |
be/src/runtime/runtime_state.cpp
Outdated
| if (query_globals.__isset.time_zone) { | ||
| _timezone = query_globals.time_zone; | ||
| _timestamp_ms = query_globals.timestamp; | ||
| } else if (query_globals.now_string != "") { |
Contributor
There was a problem hiding this comment.
can this string be empty? I think it is no need to test it
82db5ec to
3312e6c
Compare
3312e6c to
3fbd5bc
Compare
Closed
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix time zone compatibility with old fe