Add PreAgg Hint #1617
Add PreAgg Hint #1617
Conversation
fe/src/main/cup/sql_parser.cup
Outdated
| nonterminal ArrayList<String> opt_sort_hints; | ||
| nonterminal Expr sign_chain_expr; | ||
| nonterminal Qualifier union_op; | ||
| nonterminal String opt_agg_open_hints; |
There was a problem hiding this comment.
change this name? This can be hint for other purpose.
I think it should be a List, cause we can support other hints later.
| isAnalyzed = true; // true that we have assigned desc | ||
| analyzeJoin(analyzer); | ||
| analyzeSortHints(); | ||
| analyzeAggOpenedHints(); |
| ((OlapScanNode) root).setIsPreAggregation(false, turnOffReason); | ||
| if ((root instanceof OlapScanNode)) { | ||
| OlapScanNode node = (OlapScanNode) root; | ||
| for (TableRef tableRef : selectStmt.getTableRefs()) {// Force Open PreAgg |
There was a problem hiding this comment.
what do this logic means to do?
There was a problem hiding this comment.
We must have to match the table name，so we can set OpenPreAgg flags
| } | ||
|
|
||
| if (((OlapScanNode)root).getForceOpenPreAgg()) { | ||
| return;//OlapScanNode has be forced opened PreAgg then the function return directly. |
There was a problem hiding this comment.
why return?
you should call olapNode.setIsPreAggregation(true, null);
There was a problem hiding this comment.
if return value of the function getForceOpenPreAgg() is true, the OlapScanNode has be set TRUE，so we don't call olapNode.setIsPreAggregation(true, null);
| DoubleLiteral = ({FLit1}|{FLit2}|{FLit3}) {Exponent}? | ||
|
|
||
| EolHintBegin = "--" " "* "+" | ||
| CommentedHintBegin = "/*" " "* "+" |
There was a problem hiding this comment.
I think your change will cause problem for query like "select /* test */ a from test"
We can force open PreAgg function if it has'nt aggregation information in SQL.