Add page cache for column page in BetaRowset #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
reviewed
Aug 8, 2019
Contributor
|
+1. LGTM. |
morningman
reviewed
Aug 9, 2019
| << config::storage_page_cache_limit | ||
| << ", memory=" << MemInfo::physical_mem(); | ||
| } | ||
| StoragePageCache::create_global_cache(storage_cache_limit); |
Contributor
There was a problem hiding this comment.
Is that OK to set cache size larger than physical memory size?
Contributor
Author
There was a problem hiding this comment.
May be OK or may be not. Now we LOG WARNING here, we should review all cache/buffer memory in our system.
Co-Authored-By: Mingyu Chen <morningman@163.com>
kangkaisen
approved these changes
Aug 12, 2019
luwei16
pushed a commit
to luwei16/incubator-doris
that referenced
this pull request
Apr 7, 2023
…failed (apache#1607) * [fix](selectdb-cloud) Fix key column with inverted index match query failed * [chore](regression case) add regression case
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…failed (apache#1607) * [fix](selectdb-cloud) Fix key column with inverted index match query failed * [chore](regression case) add regression case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1391