Implement BetaRowsetWriter #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Aug 7, 2019
imay
reviewed
Aug 11, 2019
…loc exception in AggregateFuncTest
kangpinghuang
requested changes
Aug 12, 2019
| RowsetSharedPtr build() override; | ||
|
|
||
| MemPool* mem_pool() override; | ||
| Version version() override { return _rowset_writer_context.version; } |
Contributor
There was a problem hiding this comment.
add const description?
Contributor
Author
There was a problem hiding this comment.
ok, will fix later
|
|
||
| RowsetSharedPtr build() override; | ||
|
|
||
| Version version() override { return _context.version; } |
| _rowset_meta)); | ||
| auto status = rowset->init(); | ||
| if (status != OLAP_SUCCESS) { | ||
| LOG(WARNING) << "rowset init failed when build new rowset"; |
Contributor
There was a problem hiding this comment.
add status msg to log
Contributor
Author
There was a problem hiding this comment.
Because OLAPStatus is just an enum and doesn't have errmsg field, the real reason is usually not logged by caller, but by the function who encounters error in the first place
| OLAPStatus BetaRowsetWriter::_create_segment_writer() { | ||
| auto path = BetaRowset::segment_file_path(_context.rowset_path_prefix, _context.rowset_id, _num_segment); | ||
| segment_v2::SegmentWriterOptions writer_options; | ||
| _segment_writer.reset(new segment_v2::SegmentWriter(path, _num_segment, _context.tablet_schema, writer_options)); |
Contributor
There was a problem hiding this comment.
I think SegmentWriter can add another constructor without SegmentWriterOptions as a argument, and use the default SegmentWriterOptions
Contributor
Author
There was a problem hiding this comment.
yeah, it can be optimized in the future
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BetaRowsetWriter is used to write rowset in V2 segment format.
This PR contains several interface changes
link_files_tobecause hard links are also useful in copy task, linked schema change, etccopy_files_toto be consistent with other namesFuture works
write_mbytes_per_secbased on writer type (load/base compaction/cumulative compaction)