Skip to content

Conversation

@Kikyou1997
Copy link
Contributor

@Kikyou1997 Kikyou1997 commented Jan 11, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Reorder in analyze phase would produce a stmt which its corresponding SQL could not be analyzed correctly and cause an analyze exception that may be happened in the stmt rewrite, since the rewriter will reset and reanalyze the rewritten stmt.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jan 11, 2023
@github-actions
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In build-support/shell-check.sh line 266:
    content="$(grep 'sh_checker_exclude:' "${DORIS_HOME}/.github/workflows/code-checks.yml")"
                                           ^-----------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.


In build-support/shell-check.sh line 271:
            if echo "${file:((${#DORIS_HOME} + 1))}" | grep -E "${pattern}" &>/dev/null; then
                              ^------------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.


In build-support/shell-check.sh line 289:
    pushd "${DORIS_HOME}" >/dev/null
           ^-----------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.


In build-support/shell-check.sh line 311:
    read -r -a files < <(find_shell_scripts "${DORIS_HOME}")
                                             ^-----------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.

For more information:
  https://www.shellcheck.net/wiki/SC2031 -- DORIS_HOME was modified in a subs...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 11, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.03 seconds
load time: 487 seconds
storage size: 17122585507 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112042147_clickbench_pr_78210.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit bd2280b into apache:master Jan 13, 2023
morningman pushed a commit that referenced this pull request Jan 23, 2023
Reorder in analyze phase would produce a stmt which its corresponding SQL could not be analyzed correctly and cause an analyze exception that may be happened in the stmt rewrite, since the rewriter will reset and reanalyze the rewritten stmt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/1.2.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants