EnginePublishVersionTask: remove unreachable code #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
reviewed
Jul 29, 2019
| RowsetMetaManager::remove(tablet->data_dir()->get_meta(), tablet->tablet_uid(), rowset->rowset_id()); | ||
| // delete txn info | ||
| } else { | ||
| LOG(WARNING) << "fail to publish version on tablet. tablet=" << tablet->full_name().c_str() |
Contributor
Author
There was a problem hiding this comment.
the else clause is unreachable, please see the if statement at line 97
imay
approved these changes
Jul 30, 2019
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…rowset_data` (apache#1579) After detaching TabletSchemaPB from rowset meta (apache#1562), the recycler may dereference the null tablet schema in RowsetMetaPB. This commit accomplishes apache#1562 apache#1526.
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…rowset_data` (apache#1580) After detaching TabletSchemaPB from rowset meta (apache#1562), the recycler may dereference the null tablet schema in RowsetMetaPB. This commit accomplishes apache#1562 apache#1526.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.