[fix](merge-on-write) delete all rows with same key in all pre segments #14995
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity pipeline, clickbench performance test result: |
faa529c to
09ef519
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
be/src/olap/tablet.cpp
Outdated
| loc->row_id)) { | ||
| delete_bitmap->add({rowset_id, loc->segment_id, version.first}, loc->row_id); | ||
| } | ||
| continue; |
There was a problem hiding this comment.
Don't need continue here? Just need to find the key in the previous segment, instead of traversing all segments for mow without sequence col.
There was a problem hiding this comment.
that's rigth, i fix it
There was a problem hiding this comment.
当时has_sequence_col的时候，这里还有bug，我统一改一下吧
be/src/olap/tablet.cpp
Outdated
| auto st = _check_pk_in_pre_segments(rowset_id, pre_segments, *key, | ||
| dummy_version, delete_bitmap, &loc); | ||
| if (st.ok()) { | ||
| delete_bitmap->add({loc.rowset_id, loc.segment_id, dummy_version.first}, |
There was a problem hiding this comment.
Don't need this code, because already added in _check_pk_in_pre_segments.
There was a problem hiding this comment.
en, i fix _check_pk_in_pre_segments
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
zhannngchen
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your contribution.
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
5edb629
d020ecb to
5edb629
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Proposed changes
Issue Number: close #14994
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...