[fix][scripts]: prepare_docs.sh supports image path conversion.#789
[fix][scripts]: prepare_docs.sh supports image path conversion.#789zhongjiajie merged 4 commits intoapache:masterfrom huangchenguang123:fix/fix_scripts
Conversation
|
Please review my code @zhongjiajie .Thanks. |
|
Did you test locally? @huangchenguang123 |
Yes, I tested locally. Is there something wrong with the code? |
|
No, I just make sure about it, but is seem we do not change the img path in apache/dolphinscheculer, should we also change the path related path in directory |
If the documentation wants to be previewed in github/idea, the image path in docs should be changed. like apache/dolphinscheduler#10127. To be compatible with the website, the path needs to be rewritten in the script.From '../../../../img' to '/img'.I don't know if you understand what I mean? |
|
Did I should do someting more? @zhongjiajie |
|
@huangchenguang123 It is my bad, I am working hard on the issue of the 3.0.0-beta-1 release process. I will take a look at this issue after the version release. |
Thanks. |
will task a look tonight or tomorrow, we need more local tests about it |
|
I have checked this PR and it works fine except some comment issues and I have already fixed them in |
|
Well done and thanks @huangchenguang123 |
Use related path in our docs for imgs, previous can not use because website need the absolute path from root directory, and after we merged apache/dolphinscheduler-website#789 we have covert function to do that close: apache#9426
Use related path in our docs for imgs, previous can not use because website need the absolute path from root directory, and after we merged apache/dolphinscheduler-website#789 we have covert function to do that close: apache#9426
Use related path in our docs for imgs, previous can not use because website need the absolute path from root directory, and after we merged apache/dolphinscheduler-website#789 we have covert function to do that close: #9426
Use related path in our docs for imgs, previous can not use because website need the absolute path from root directory, and after we merged apache/dolphinscheduler-website#789 we have covert function to do that close: apache#9426
Since viewing md on github requires a relative path, use '../../../../'.
so it will convert img path and make them work bot github markdown and website.
see my code in apache/dolphinscheduler#10127