Skip to content

[Feature-7465][Alert] Modifiy alert docs#594

Merged
zhongjiajie merged 8 commits intoapache:masterfrom
SbloodyS:feature_7465
Dec 27, 2021
Merged

[Feature-7465][Alert] Modifiy alert docs#594
zhongjiajie merged 8 commits intoapache:masterfrom
SbloodyS:feature_7465

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS commented Dec 17, 2021 •
edited
Loading

zhongjiajie
zhongjiajie requested changes Dec 22, 2021
View reviewed changes
@SbloodyS
Copy link
Copy Markdown
Member Author

SbloodyS commented Dec 23, 2021

@zhongjiajie Please review again.thanks.

@zhongjiajie zhongjiajie added this to the 2.0.2 milestone Dec 27, 2021
@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Dec 27, 2021

code looks good to me. I would merge this patch after CI pass. One more thing, I suggest to operate the unrelated doc next time to make our changelog more sense. In this PR, I prefer to submit two PR, one change wechat API doc, another change build-in parameter

@zhongjiajie zhongjiajie self-requested a review December 27, 2021 03:34
@SbloodyS
Copy link
Copy Markdown
Member Author

SbloodyS commented Dec 27, 2021

code looks good to me. I would merge this patch after CI pass. One more thing, I suggest to operate the unrelated doc next time to make our changelog more sense. In this PR, I prefer to submit two PR, one change wechat API doc, another change build-in parameter

thanks.

@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Dec 27, 2021 •
edited
Loading

I was odd that CI would be canceled for no reason.

@SbloodyS
Copy link
Copy Markdown
Member Author

SbloodyS commented Dec 27, 2021

I was odd that CI would be canceled for no reason.

It seems stuck in Run for file in $(find . -name "*.md"); do. Maybe the CI server is busy and the command cannot be executed？

zhongjiajie
zhongjiajie approved these changes Dec 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Dec 27, 2021

It found a dead link which we just add to repo should could not be found, I think our dead link test should be improve to avoid this happend. https://github.com/apache/dolphinscheduler-website/runs/4639544230?check_suite_focus=true
image

@zhongjiajie zhongjiajie merged commit 5a063d5 into apache:master Dec 27, 2021
@zhongjiajie zhongjiajie mentioned this pull request Dec 27, 2021
Closed
3 tasks
@SbloodyS SbloodyS deleted the feature_7465 branch December 27, 2021 06:59
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-website that referenced this pull request Dec 29, 2021
@zhongjiajie
pick from apache#594
dd81e86
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-website that referenced this pull request Jan 5, 2022
@zhongjiajie
Correct alert, pick from apache#594
620e626
davidzollo pushed a commit that referenced this pull request Jan 6, 2022
@zhongjiajie
Add new release doc for 2.0.2 (#612)
c3a89e9 
* Add new release doc for 2.0.2

* Switch version to 2.0.2

* Correct alert, pick from #594

* Change fault tolerance, pick from #610

* Add python gateway server start

* Fix doc 202 lead to 201

* Correct release date to Jan 5th

* Fix dead link, pick from #609

* Remove ambari related, pick from apache/dolphinscheduler#7749

* Change mysql jdbc version, pick from #617

* Recover init database shortcut, pick from apache/dolphinscheduler#7530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

Assignees

@SbloodyS SbloodyS

Labels

First-time contributor

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@SbloodyS @zhongjiajie @davidzollo