added multiple lines shell example#133
Conversation
|
@ zhongjiajie please review it once. I have made changes in shell task also added parameter for our example and string formatting as well. |
zhongjiajie
left a comment
There was a problem hiding this comment.
Hi @HarshitNagpal29 we should not format the string via python format, we should use https://dolphinscheduler.apache.org/en-us/docs/3.2.0/guide/parameter/local mechanism to do that, because we have some dynamic parameter like $[yyyy-MM-dd] for executing date
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 64 64
Lines 2361 2361
=======================================
Hits 2147 2147
Misses 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fix: apache/dolphinscheduler#8955
Brief Summary of The Change
Pull Request checklist
I confirm that the following checklist has been completed.
docs/source/config.rstwhen you change filedefault_config.yaml.UPDATING.mdwhen it is an incompatible change.