[Feature-7346] [Python]Add workflow as code task type spark#7968
Merged
zhongjiajie merged 5 commits intoapache:devfrom Jan 15, 2022
Merged
[Feature-7346] [Python]Add workflow as code task type spark#7968zhongjiajie merged 5 commits intoapache:devfrom
zhongjiajie merged 5 commits intoapache:devfrom
Conversation
Contributor
Author
|
PTAL @zhongjiajie |
Member
|
I restart the failing CI test |
zhongjiajie
reviewed
Jan 14, 2022
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/flink.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/spark.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
PTAL @zhongjiajie |
Member
|
I restart the failing e2e test |
zhongjiajie
previously approved these changes
Jan 14, 2022
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/engine.py
Outdated
Show resolved
Hide resolved
zhongjiajie
reviewed
Jan 14, 2022
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/engine.py
Outdated
Show resolved
Hide resolved
Contributor
Author
Thank's for your review. |
Member
No, I thank you, Kai, for the contribution. BTW, We still need to waiting CI passed 👀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #7968 +/- ##
============================================
+ Coverage 41.10% 41.30% +0.19%
- Complexity 3705 3726 +21
============================================
Files 637 637
Lines 27058 27129 +71
Branches 3073 3083 +10
============================================
+ Hits 11122 11205 +83
+ Misses 14862 14849 -13
- Partials 1074 1075 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kudos, SonarCloud Quality Gate passed!
|
yimaixinchen
pushed a commit
to yimaixinchen/dolphinscheduler
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7346