Skip to content

[deploy] Split Ambari plugin to independent repo#7880

Merged
CalvinKirs merged 1 commit intoapache:devfrom
zhongjiajie:dp-rm-ambari
Jan 7, 2022
Merged

[deploy] Split Ambari plugin to independent repo#7880
CalvinKirs merged 1 commit intoapache:devfrom
zhongjiajie:dp-rm-ambari

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Jan 7, 2022

fix: #7036

@zhongjiajie zhongjiajie self-assigned this Jan 7, 2022
@zhongjiajie zhongjiajie added minor Chore Chores about the project, like code clean, typo, etc. CI&CD labels Jan 7, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #7880 (5aa7580) into dev (120c175) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7880      +/-   ##
============================================
- Coverage     41.18%   40.99%   -0.19%     
- Complexity     3669     3693      +24     
============================================
  Files           641      637       -4     
  Lines         26525    27044     +519     
  Branches       2964     3067     +103     
============================================
+ Hits          10924    11087     +163     
- Misses        14575    14890     +315     
- Partials       1026     1067      +41
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/server/log/LoggerRequestProcessor.java 20.31% <0.00%> (-39.07%) ⬇️
...inscheduler/api/controller/ExecutorController.java 10.00% <0.00%> (-15.00%) ⬇️
...e/dolphinscheduler/api/aspect/AccessLogAspect.java 67.24% <0.00%> (-13.72%) ⬇️
...er/api/service/impl/TaskDefinitionServiceImpl.java 22.04% <0.00%> (-9.80%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...heduler/api/service/impl/TaskGroupServiceImpl.java 60.17% <0.00%> (-3.83%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120c175...5aa7580. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie zhongjiajie changed the title [deploy] Split Ambari plugin to independent repo [Don't merge][deploy] Split Ambari plugin to independent repo Jan 7, 2022
CalvinKirs
CalvinKirs reviewed Jan 7, 2022
View reviewed changes
CalvinKirs
CalvinKirs approved these changes Jan 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 9b6b381 into apache:dev Jan 7, 2022
@zhongjiajie zhongjiajie deleted the dp-rm-ambari branch January 7, 2022 13:10
@zhongjiajie zhongjiajie changed the title [Don't merge][deploy] Split Ambari plugin to independent repo [deploy] Split Ambari plugin to independent repo Jan 7, 2022
@zhongjiajie zhongjiajie mentioned this pull request Jan 7, 2022
Closed
3 tasks
zhongjiajie added a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jan 13, 2022
@zhongjiajie
Remove ambari plugin profile in 2.0.3
11f4616 
We already total remove ambari in dev branch
by apache#7880, and in version 2.0.2 just remove
ambari plugin directory in apache#7749. This patch
also remove related profiles of ambari plugin
@zhongjiajie zhongjiajie mentioned this pull request Jan 13, 2022
Merged
caishunfeng pushed a commit that referenced this pull request Jan 13, 2022
@zhongjiajie
Remove ambari plugin profile in 2.0.3 (#8011)
600ee5e 
We already total remove ambari in dev branch
by #7880, and in version 2.0.2 just remove
ambari plugin directory in #7749. This patch
also remove related profiles of ambari plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@davidzollo davidzollo Awaiting requested review from davidzollo

Assignees

@zhongjiajie zhongjiajie

Labels

CI&CD minor Chore Chores about the project, like code clean, typo, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][deploy] Split Ambari plugin to independent repo

3 participants

@zhongjiajie @codecov-commenter @CalvinKirs