[Fix-7713] Handling the sensitive data in the log#7728
Merged
zhuangchong merged 4 commits intoapache:devfrom Dec 30, 2021
Merged
[Fix-7713] Handling the sensitive data in the log#7728zhuangchong merged 4 commits intoapache:devfrom
zhuangchong merged 4 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7728 +/- ##
=========================================
Coverage 41.09% 41.10%
- Complexity 3675 3677 +2
=========================================
Files 642 642
Lines 26662 26678 +16
Branches 2992 2995 +3
=========================================
+ Hits 10957 10965 +8
- Misses 14658 14661 +3
- Partials 1047 1052 +5
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
pushed a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Jan 13, 2022
* add a feature to handle sensitive data
lenboo
pushed a commit
that referenced
this pull request
Jan 13, 2022
* finished issue#7527 (#7561) Co-authored-by: 时光 <caizhedong@cai-inc.com> * [Fix-7713] Handling the sensitive data in the log (#7728) * add a feature to handle sensitive data * [cherry-pick-2.0.3]fix-#7740-upgrade_sql #7761 * [cherry-pick-2.0.3][Fix-7203] Remedy the issue about importing a process json file * [cherry-pick-2.0.3][Fix-7857] The user won't be allowed to disable their own account Co-authored-by: 时光 <41109695+yikeshiguang@users.noreply.github.com> Co-authored-by: 时光 <caizhedong@cai-inc.com> Co-authored-by: calvin <jianghuachinacom@163.com> Co-authored-by: uh001 <96870549+uh001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This PR will close #7713 .
Brief change log
When requesting api interface, the class AccessLogAspect will output the logs about the request parameters. But somtimes the request parameters includes a few sensitive data like password. So I add a function to deal with the writing logs that contains 'password' , and then it will convert the value of 'password' into '****'.
Verify this pull request
This change added tests and can be verified as follows:
I manually verify the new function, and it can successfully pass through the test case.