[python] Fix task condition set wrong deps#7650
Merged
caishunfeng merged 1 commit intoapache:devfrom Dec 27, 2021
Merged
Conversation
After apache#7505 merged. we could use condition task type but our dependent set in the wrong direction, all the condition operators should be upstream of the current task instead of downstream fix: apache#7649
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #7650 +/- ##
============================================
+ Coverage 41.18% 41.21% +0.03%
- Complexity 3667 3669 +2
============================================
Files 641 641
Lines 26540 26540
Branches 2967 2967
============================================
+ Hits 10930 10939 +9
+ Misses 14579 14574 -5
+ Partials 1031 1027 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kudos, SonarCloud Quality Gate passed!
|
kezhenxu94
approved these changes
Dec 27, 2021
Member
Author
|
Thanks~ |
zhongjiajie
added a commit
to zhongjiajie/dolphinscheduler
that referenced
this pull request
Dec 28, 2021
After apache#7505 merged. we could use condition task type but our dependent set in the wrong direction, all the condition operators should be upstream of the current task instead of downstream fix: apache#7649
zhongjiajie
added a commit
that referenced
this pull request
Dec 28, 2021
aaronlinv
pushed a commit
to aaronlinv/dolphinscheduler
that referenced
this pull request
Dec 28, 2021
After apache#7505 merged. we could use condition task type but our dependent set in the wrong direction, all the condition operators should be upstream of the current task instead of downstream fix: apache#7649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7505 merged. we could use condition task type
but our dependent set in the wrong direction, all
the condition operators should be upstream of the
current task instead of downstream
fix: #7649