Skip to content

[Feature][UI Next] Update card component props.#7635

Merged
zhongjiajie merged 1 commit intoapache:devfrom
songjianet:feat-card
Dec 27, 2021
Merged

[Feature][UI Next] Update card component props.#7635
zhongjiajie merged 1 commit intoapache:devfrom
songjianet:feat-card

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

close #7605

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 27, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.13%. Comparing base (2d73083) to head (e44fef1).
⚠️ Report is 3265 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7635      +/-   ##
============================================
- Coverage     41.15%   41.13%   -0.02%     
+ Complexity     3665     3662       -3     
============================================
  Files           641      641              
  Lines         26539    26539              
  Branches       2967     2967              
============================================
- Hits          10921    10917       -4     
- Misses        14590    14595       +5     
+ Partials       1028     1027       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zhongjiajie zhongjiajie merged commit 36dd437 into apache:dev Dec 27, 2021
Copy link
Copy Markdown
Member

@wangyizhi1 wangyizhi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie added the UI ui and front end related label Dec 27, 2021
@songjianet songjianet deleted the feat-card branch December 27, 2021 09:24
aaronlinv pushed a commit to aaronlinv/dolphinscheduler that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][UI Next] Add card component.

5 participants