Skip to content

[Bug-7474][MasterServer] fix failover when node host is null#7475

Merged
lenboo merged 6 commits intoapache:devfrom
caishunfeng:failover
Dec 28, 2021
Merged

[Bug-7474][MasterServer] fix failover when node host is null#7475
lenboo merged 6 commits intoapache:devfrom
caishunfeng:failover

Conversation

@caishunfeng
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng commented Dec 17, 2021

this pr close #7474
add failover execute thread.

image

continue;
}
processInstanceCacheMap.put(processInstance.getId(), processInstance);
taskInstance.setProcessInstance(processInstance);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same code in failoverTaskInstance

@caishunfeng caishunfeng requested a review from lenboo December 20, 2021 14:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 21, 2021

Codecov Report

❌ Patch coverage is 27.64228% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.08%. Comparing base (2d73083) to head (a632f16).
⚠️ Report is 3279 commits behind head on dev.

Files with missing lines Patch % Lines
...r/server/master/registry/MasterRegistryClient.java 33.33% 33 Missing and 15 partials ⚠️
...er/server/master/runner/FailoverExecuteThread.java 0.00% 32 Missing ⚠️
...inscheduler/server/master/config/MasterConfig.java 66.66% 2 Missing ⚠️
...er/master/registry/MasterRegistryDataListener.java 0.00% 2 Missing ⚠️
...e/dolphinscheduler/server/master/MasterServer.java 0.00% 1 Missing ⚠️
...er/server/master/runner/WorkflowExecuteThread.java 0.00% 1 Missing ⚠️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 0.00% 1 Missing ⚠️
...lphinscheduler/service/process/ProcessService.java 75.00% 1 Missing ⚠️
...phinscheduler/service/registry/RegistryClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7475      +/-   ##
============================================
- Coverage     41.15%   41.08%   -0.07%     
- Complexity     3665     3672       +7     
============================================
  Files           641      642       +1     
  Lines         26539    26620      +81     
  Branches       2967     2984      +17     
============================================
+ Hits          10921    10938      +17     
- Misses        14590    14638      +48     
- Partials       1028     1044      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

37.0% 37.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 8808c0a into apache:dev Dec 28, 2021
@caishunfeng caishunfeng deleted the failover branch February 17, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] failover error when single master restart

3 participants