[Feature-6918][UI] DAG page interaction optimization#6919
Merged
davidzollo merged 8 commits intoapache:devfrom Nov 19, 2021
Merged
[Feature-6918][UI] DAG page interaction optimization#6919davidzollo merged 8 commits intoapache:devfrom
davidzollo merged 8 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6919 +/- ##
============================================
- Coverage 33.07% 33.03% -0.05%
+ Complexity 1626 1625 -1
============================================
Files 433 433
Lines 14365 14365
Branches 1437 1437
============================================
- Hits 4751 4745 -6
- Misses 9158 9168 +10
+ Partials 456 452 -4
Continue to review full report at Codecov.
|
Contributor
|
excellent design +1 |
songjianet
reviewed
Nov 19, 2021
| display: flex; | ||
| justify-content: center; | ||
|
|
||
| /deep/ .el-slider__runway{ |
Member
There was a problem hiding this comment.
It is recommended to replace /deep/ with ::v-deep.
| @@ -80,7 +80,6 @@ body{ | |||
| //background: #f8fbfe; | |||
| } | |||
| .conditions-model { | |||
Member
There was a problem hiding this comment.
This will conflict with the pr of https://github.com/apache/dolphinscheduler/pull/6911/files, which requires local rebase.
b677872 to
f07331e
Compare
songjianet
approved these changes
Nov 19, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
LGTM |
davidzollo
approved these changes
Nov 19, 2021
Contributor
davidzollo
left a comment
There was a problem hiding this comment.
+1
great job
so amazing!
3 tasks
wangyizhi1
added a commit
to cmss-bfs/dolphinscheduler
that referenced
this pull request
Dec 2, 2021
* [Feature] Add grid layout and optimize DAG style * [Improvement] Add process definition status label and code optimization * [Feature] add DAG node search bar * [Feature] Add DAG scale bar * [Improvement] Open pre-tasks settings for all tasks * [Fix] Fix ut * [Fix] Replace /deep/ with ::v-deep * [Fix] Fix code smell
brave-lee
pushed a commit
that referenced
this pull request
Dec 3, 2021
…#7137) * [Feature-6918][UI] DAG page interaction optimization (#6919) * [Feature] Add grid layout and optimize DAG style * [Improvement] Add process definition status label and code optimization * [Feature] add DAG node search bar * [Feature] Add DAG scale bar * [Improvement] Open pre-tasks settings for all tasks * [Fix] Fix ut * [Fix] Replace /deep/ with ::v-deep * [Fix] Fix code smell * [Improvement-7092][UI] Optimize DAG to adapt to situations without locations (#7102)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6918
Add grid layout function.
Open pre-tasks settings for all tasks
Add node search function
Add DAG scale bar
Add process status tag
Optimize node feedback when creating connection
