Skip to content

Fix the definition error of loginInterceptor#6669

Merged
CalvinKirs merged 1 commit intoapache:devfrom
ouyangyewei429:issue/fixRegisterPathPattern
Nov 4, 2021
Merged

Fix the definition error of loginInterceptor#6669
CalvinKirs merged 1 commit intoapache:devfrom
ouyangyewei429:issue/fixRegisterPathPattern

Conversation

@ouyangyewei429
Copy link
Copy Markdown
Contributor

@ouyangyewei429 ouyangyewei429 commented Nov 2, 2021

The patch fixes the error defined in the REGISTER_PATH_PATTERN, and the authentication cannot be exempted when the api /dolphinscheduler/users/register is called.

@ouyangyewei429 ouyangyewei429 changed the title fix REGISTER_PATH_PATTERN Fix the definition error of loginInterceptor Nov 2, 2021
Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 3, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.47%. Comparing base (26a84b3) to head (8d5da85).
⚠️ Report is 3544 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6669      +/-   ##
============================================
- Coverage     38.49%   38.47%   -0.02%     
+ Complexity     3226     3224       -2     
============================================
  Files           646      646              
  Lines         25886    25886              
  Branches       2808     2808              
============================================
- Hits           9964     9960       -4     
- Misses        15007    15013       +6     
+ Partials        915      913       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CalvinKirs CalvinKirs added the first time contributor First-time contributor label Nov 3, 2021
@ouyangyewei429
Copy link
Copy Markdown
Contributor Author

@CalvinKirs pls review, tks ;)

@CalvinKirs CalvinKirs merged commit 0b93fd5 into apache:dev Nov 4, 2021
@CalvinKirs
Copy link
Copy Markdown
Member

thanks for your first contribution. good job
please only submit the related resources for this PR, one PR just solves one issue
I think you will need my help, please contact me freely(wechat: Kris_Evil), when added, please tell me your github id

Welcome to join the DolphinScheduler Community!!!

@ouyangyewei429 ouyangyewei429 deleted the issue/fixRegisterPathPattern branch November 4, 2021 03:13
ouyangyewei429 pushed a commit to ouyangyewei429/dolphinscheduler that referenced this pull request Dec 13, 2021
lenboo pushed a commit that referenced this pull request Dec 13, 2021
Co-authored-by: ouyangyewei <yewei.oyyw@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants